You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Kirill Tkalenko (Jira)" <ji...@apache.org> on 2024/02/02 06:58:00 UTC
[jira] [Comment Edited] (IGNITE-21419) Optimize listener collection update in AbstractEventProducer
[ https://issues.apache.org/jira/browse/IGNITE-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813510#comment-17813510 ]
Kirill Tkalenko edited comment on IGNITE-21419 at 2/2/24 6:57 AM:
------------------------------------------------------------------
My variant not optimal, I have attached a [^RemoveWithCopyListMicroBenchmark.java] and its results:
{noformat}
Benchmark Mode Cnt Score Error Units
RemoveWithCopyListMicroBenchmark.remove100_000_middle_new avgt 25 865788,301 � 139764,886 ns/op
RemoveWithCopyListMicroBenchmark.remove100_000_middle_old avgt 25 717813,727 � 79712,872 ns/op
RemoveWithCopyListMicroBenchmark.remove100_middle_new avgt 25 892,892 � 85,316 ns/op
RemoveWithCopyListMicroBenchmark.remove100_middle_old avgt 25 731,736 � 99,779 ns/op
RemoveWithCopyListMicroBenchmark.remove10_000_middle_new avgt 25 85465,439 � 27578,902 ns/op
RemoveWithCopyListMicroBenchmark.remove10_000_middle_old avgt 25 62351,185 � 5958,444 ns/op
RemoveWithCopyListMicroBenchmark.remove10_middle_new avgt 25 222,722 � 56,660 ns/op
RemoveWithCopyListMicroBenchmark.remove10_middle_old avgt 25 92,436 � 15,677 ns/op
RemoveWithCopyListMicroBenchmark.remove1_000_000_middle_new avgt 25 16297910,000 � 1053968,832 ns/op
RemoveWithCopyListMicroBenchmark.remove1_000_000_middle_old avgt 25 17191652,000 � 801548,036 ns/op
RemoveWithCopyListMicroBenchmark.remove1_000_middle_new avgt 25 8885,919 � 1442,966 ns/op
RemoveWithCopyListMicroBenchmark.remove1_000_middle_old avgt 25 6076,685 � 907,782 ns/op
{noformat}
was (Author: ktkalenko@gridgain.com):
My variant not optimal, I have attached a benchmark and its results:
{noformat}
Benchmark Mode Cnt Score Error Units
RemoveWithCopyListMicroBenchmark.remove100_000_middle_new avgt 25 865788,301 � 139764,886 ns/op
RemoveWithCopyListMicroBenchmark.remove100_000_middle_old avgt 25 717813,727 � 79712,872 ns/op
RemoveWithCopyListMicroBenchmark.remove100_middle_new avgt 25 892,892 � 85,316 ns/op
RemoveWithCopyListMicroBenchmark.remove100_middle_old avgt 25 731,736 � 99,779 ns/op
RemoveWithCopyListMicroBenchmark.remove10_000_middle_new avgt 25 85465,439 � 27578,902 ns/op
RemoveWithCopyListMicroBenchmark.remove10_000_middle_old avgt 25 62351,185 � 5958,444 ns/op
RemoveWithCopyListMicroBenchmark.remove10_middle_new avgt 25 222,722 � 56,660 ns/op
RemoveWithCopyListMicroBenchmark.remove10_middle_old avgt 25 92,436 � 15,677 ns/op
RemoveWithCopyListMicroBenchmark.remove1_000_000_middle_new avgt 25 16297910,000 � 1053968,832 ns/op
RemoveWithCopyListMicroBenchmark.remove1_000_000_middle_old avgt 25 17191652,000 � 801548,036 ns/op
RemoveWithCopyListMicroBenchmark.remove1_000_middle_new avgt 25 8885,919 � 1442,966 ns/op
RemoveWithCopyListMicroBenchmark.remove1_000_middle_old avgt 25 6076,685 � 907,782 ns/op
{noformat}
> Optimize listener collection update in AbstractEventProducer
> ------------------------------------------------------------
>
> Key: IGNITE-21419
> URL: https://issues.apache.org/jira/browse/IGNITE-21419
> Project: Ignite
> Issue Type: Improvement
> Reporter: Kirill Tkalenko
> Assignee: Kirill Tkalenko
> Priority: Minor
> Labels: ignite-3
> Fix For: 3.0.0-beta2
>
> Attachments: RemoveWithCopyListMicroBenchmark.java
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I discovered that updating the collection of listeners in *org.apache.ignite.internal.event.AbstractEventProducer* is a little not optimal, I’m optimizing it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)