[GitHub] [beam] AnandInguva commented on pull request #25398: Add batching args to ModelHandlers docs

["AnandInguva (via GitHub)" <gi...@apache.org>]

AnandInguva commented on PR #25398:
URL: https://github.com/apache/beam/pull/25398#issuecomment-1425985670

   > > Took this[1] from https://beam.apache.org/releases/pydoc/2.22.0/apache_beam.transforms.util.html#apache_beam.transforms.util.BatchElements
   > > Can we add some information on [1] as well?
   > > [1] This transform attempts to find the best batch size between the minimim and maximum parameters by profiling the time taken by (fused) downstream operations. For a fixed batch size, set the min and max to be equal.
   > 
   > @AnandInguva I actually intentionally avoided talking about the mechanisms we use for batching (`BatchElements`) because this could change and isn't really part of our public API here. In the future we may switch some or all of our usage to `GroupIntoBatches` (at which point we'd probably pick a reasonable batch size within the min/max limits and all batching would be of fixed size)
   > 
   > Basically, I don't want to leak implementation details that _shouldn't_ impact how users use the transform
   
   Thats sounds reasonable. Thanks for the info. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org