[GitHub] [iceberg] rdblue commented on a diff in pull request #4769: Api: add sequenceNumber method

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4769:
URL: https://github.com/apache/iceberg/pull/4769#discussion_r873060170


##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -205,6 +207,15 @@ void setSpecId(int specId) {
     this.partitionSpecId = specId;
   }
 
+  @Override
+  public Long sequenceNumber() {
+    return sequenceNumber;
+  }
+
+  void setSequenceNumber(Long seq) {

Review Comment:
   Sequence number is tracked by the manifest entry, not the content file. And I don't think it is a good idea to make this mutable. What is the rationale for adding it here (not just a ref to another issue)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org