You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by sn...@apache.org on 2024/07/11 19:42:35 UTC

(flink) branch master updated: [hotfix][table] Apply uppercase for URL_ENCODE/URL_DECODE remove logging from function class

This is an automated email from the ASF dual-hosted git repository.

snuyanzin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 047a1c0e5d2 [hotfix][table] Apply uppercase for URL_ENCODE/URL_DECODE remove logging from function class
047a1c0e5d2 is described below

commit 047a1c0e5d26ff12649fde1eca15b8caa6e4745f
Author: Sergey Nuyanzin <sn...@gmail.com>
AuthorDate: Thu Jul 11 21:42:29 2024 +0200

    [hotfix][table] Apply uppercase for URL_ENCODE/URL_DECODE remove logging from function class
---
 .../apache/flink/table/functions/BuiltInFunctionDefinitions.java | 8 ++++----
 .../flink/table/runtime/functions/scalar/UrlDecodeFunction.java  | 9 ---------
 .../flink/table/runtime/functions/scalar/UrlEncodeFunction.java  | 9 ---------
 3 files changed, 4 insertions(+), 22 deletions(-)

diff --git a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
index 1b729fe5858..f64b4a105b8 100644
--- a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
+++ b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
@@ -433,20 +433,20 @@ public final class BuiltInFunctionDefinitions {
 
     public static final BuiltInFunctionDefinition URL_DECODE =
             BuiltInFunctionDefinition.newBuilder()
-                    .name("url_decode")
+                    .name("URL_DECODE")
                     .kind(SCALAR)
                     .inputTypeStrategy(sequence(logical(LogicalTypeFamily.CHARACTER_STRING)))
-                    .outputTypeStrategy(nullableIfArgs(explicit(DataTypes.STRING().nullable())))
+                    .outputTypeStrategy(explicit(DataTypes.STRING().nullable()))
                     .runtimeClass(
                             "org.apache.flink.table.runtime.functions.scalar.UrlDecodeFunction")
                     .build();
 
     public static final BuiltInFunctionDefinition URL_ENCODE =
             BuiltInFunctionDefinition.newBuilder()
-                    .name("url_encode")
+                    .name("URL_ENCODE")
                     .kind(SCALAR)
                     .inputTypeStrategy(sequence(logical(LogicalTypeFamily.CHARACTER_STRING)))
-                    .outputTypeStrategy(nullableIfArgs(explicit(DataTypes.STRING().nullable())))
+                    .outputTypeStrategy(explicit(DataTypes.STRING().nullable()))
                     .runtimeClass(
                             "org.apache.flink.table.runtime.functions.scalar.UrlEncodeFunction")
                     .build();
diff --git a/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java
index 3eef21f5d4d..dba7ff1b69b 100644
--- a/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java
+++ b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java
@@ -23,9 +23,6 @@ import org.apache.flink.table.data.StringData;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.functions.SpecializedFunction;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import javax.annotation.Nullable;
 
 import java.io.UnsupportedEncodingException;
@@ -36,7 +33,6 @@ import java.nio.charset.StandardCharsets;
 /** Implementation of {@link BuiltInFunctionDefinitions#URL_DECODE}. */
 @Internal
 public class UrlDecodeFunction extends BuiltInScalarFunction {
-    private static final Logger LOG = LoggerFactory.getLogger(UrlDecodeFunction.class);
 
     public UrlDecodeFunction(SpecializedFunction.SpecializedContext context) {
         super(BuiltInFunctionDefinitions.URL_DECODE, context);
@@ -50,11 +46,6 @@ public class UrlDecodeFunction extends BuiltInScalarFunction {
         try {
             return StringData.fromString(URLDecoder.decode(value.toString(), charset.name()));
         } catch (UnsupportedEncodingException | RuntimeException e) {
-            LOG.error(
-                    "Failed to decode the input: {} with charset: {}, and the exception details: ",
-                    value,
-                    charset.name(),
-                    e);
             return null;
         }
     }
diff --git a/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java
index 623c398592c..f2c847fa856 100644
--- a/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java
+++ b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java
@@ -23,9 +23,6 @@ import org.apache.flink.table.data.StringData;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.functions.SpecializedFunction;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import javax.annotation.Nullable;
 
 import java.io.UnsupportedEncodingException;
@@ -36,7 +33,6 @@ import java.nio.charset.StandardCharsets;
 /** Implementation of {@link BuiltInFunctionDefinitions#URL_ENCODE}. */
 @Internal
 public class UrlEncodeFunction extends BuiltInScalarFunction {
-    private static final Logger LOG = LoggerFactory.getLogger(UrlEncodeFunction.class);
 
     public UrlEncodeFunction(SpecializedFunction.SpecializedContext context) {
         super(BuiltInFunctionDefinitions.URL_ENCODE, context);
@@ -50,11 +46,6 @@ public class UrlEncodeFunction extends BuiltInScalarFunction {
         try {
             return StringData.fromString(URLEncoder.encode(url.toString(), charset.name()));
         } catch (UnsupportedEncodingException e) {
-            LOG.error(
-                    "Failed to encode the input: {} with charset: {}, and the exception details: ",
-                    url,
-                    charset.name(),
-                    e);
             return null;
         }
     }