[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3365: Review use of panic in datafusion-proto crate

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #3365:
URL: https://github.com/apache/arrow-datafusion/pull/3365#discussion_r964064924


##########
datafusion/proto/src/logical_plan.rs:
##########
@@ -385,7 +385,8 @@ impl AsLogicalPlan for LogicalPlanNode {
                 let table_paths = &scan
                     .paths
                     .iter()
-                    .map(|p| ListingTableUrl::parse(p).unwrap())
+                    .filter_map(|p| ListingTableUrl::parse(p).ok())
+                    //.map(|p| ListingTableUrl::parse(p).unwrap())
                     .collect::<Vec<ListingTableUrl>>();

Review Comment:
   We don't want to silently ignore errors. How about this approach instead?
   
   ```suggestion
                       .map(|p| ListingTableUrl::parse(p))
                       .collect::<Result<Vec<_>, _>>()?;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org