[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1939: IGNITE-18345 SQL. Fix usage of java Date/Time API classes as parameters for query

["korlov42 (via GitHub)" <gi...@apache.org>]

korlov42 commented on code in PR #1939:
URL: https://github.com/apache/ignite-3/pull/1939#discussion_r1170960536


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDynamicParameterTest.java:
##########
@@ -59,19 +64,28 @@ public void dropTables() {
         sql("DROP TABLE IF EXISTS t1");
     }
 
-    @ParameterizedTest
-    @EnumSource(value = ColumnType.class,
-            //    https://issues.apache.org/jira/browse/IGNITE-18789
-            //    https://issues.apache.org/jira/browse/IGNITE-18414
-            //    https://issues.apache.org/jira/browse/IGNITE-18345
-            names = {"DECIMAL", "NUMBER", "BITMASK", "DURATION", "DATETIME", "TIMESTAMP", "DATE", "TIME", "PERIOD"},
-            mode = Mode.EXCLUDE
-    )
-    void testMetadataTypesForDynamicParameters(ColumnType type) {
-        Object param = generateValueByType(RND.nextInt(), type);
-
-        assertQuery("SELECT typeof(?)").withParams(param).returns(toSqlType(type)).check();
-        assertQuery("SELECT ?").withParams(param).returns(param).columnMetadata(new MetadataMatcher().type(type)).check();
+    @Test
+    void testMetadataTypesForDynamicParameters() {
+        //    https://issues.apache.org/jira/browse/IGNITE-18789
+        //    https://issues.apache.org/jira/browse/IGNITE-18414
+        String[] excludedTypes = {"DECIMAL", "NUMBER", "BITMASK", "DURATION", "PERIOD"};

Review Comment:
   you just removed the symptoms while the problem still exists



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org