You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/14 08:21:43 UTC

[GitHub] [spark] LuciferYang opened a new pull request #35508: [SPARK-36488][SQL][FOLLOWUP] Simplify the implementation of ResolveReferences#extractStar

LuciferYang opened a new pull request #35508:
URL: https://github.com/apache/spark/pull/35508


   ### What changes were proposed in this pull request?
   SPARK-36488 defines the `ResolveReferences#extractStar` and it use `map+flatten` code pattern, this or simplifies it to `flatMap` and reduces one collection conversion while maintaining the same semantics.
   
   
   ### Why are the changes needed?
   Code simplification
   
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao commented on pull request #35508: [SPARK-36488][SQL][FOLLOWUP] Simplify the implementation of ResolveReferences#extractStar

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #35508:
URL: https://github.com/apache/spark/pull/35508#issuecomment-1053195409


   Merged to master. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #35508: [SPARK-36488][SQL][FOLLOWUP] Simplify the implementation of ResolveReferences#extractStar

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35508:
URL: https://github.com/apache/spark/pull/35508#issuecomment-1053198373


   thanks all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao closed pull request #35508: [SPARK-36488][SQL][FOLLOWUP] Simplify the implementation of ResolveReferences#extractStar

Posted by GitBox <gi...@apache.org>.
huaxingao closed pull request #35508:
URL: https://github.com/apache/spark/pull/35508


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org