[GitHub] [airflow] subkanthi commented on a change in pull request #20794: Helm Chart - support for priorityClassName

[GitBox <gi...@apache.org>]

subkanthi commented on a change in pull request #20794:
URL: https://github.com/apache/airflow/pull/20794#discussion_r793236222



##########
File path: chart/values.yaml
##########
@@ -514,6 +514,7 @@ workers:
 
   # Select certain nodes for airflow worker pods.
   nodeSelector: {}
+  priorityClassName: ""

Review comment:
       @jedcunningham , if I have it as tilde(~), then the validation fails, thoughts
   
   ```
   Processing file:  chart/values.yaml
   None is not of type 'string'
   
   Failed validating 'type' in schema['properties']['workers']['properties']['priorityClassName']:
       {'default': '',
        'description': 'Set priority value from the priority class name',
        'type': 'string'}
   
   On instance['workers']['priorityClassName']:
       None
   None is not equal to the default of 
   
   Failed validating 'default' in schema['properties']['workers']['properties']['priorityClassName']:
       {'default': '',
        'description': 'Set priority value from the priority class name',
        'type': 'string'}
   
   On instance['workers']['priorityClassName']:
       None
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org