You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/10/18 13:40:37 UTC

[PR] Set the 10.0.x branch version to 10.0.0-SNAPSHOT and githubBranch to 10.0.x [grails-core]

borinquenkid opened a new pull request, #16669:
URL: https://github.com/apache/grails-core/pull/16669

   10.0.x was branched from 9.1.x without the version bump, so `gradle.properties` still says `projectVersion=9.1.0-SNAPSHOT` and `githubBranch=9.1.x`. The `Validate githubBranch` job (added in 42fbeb7e93) therefore fails on every pull request whose base is 10.0.x (for example #16572), and on the 10.0.x pushes themselves once one completes.
   
   Same four files as the 9.1.x bump in 829de6092e: `gradle.properties`, `GrailsUtilTests`, `THREAT_MODEL.md`, `threat-model.yaml`.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Set the 10.0.x branch version to 10.0.0-SNAPSHOT and githubBranch to 10.0.x [grails-core]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16669:
URL: https://github.com/apache/grails-core/pull/16669#issuecomment-6251151886

   ## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16669?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`10.0.x@ec6998e`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/grails-core/pull/16669/graphs/tree.svg?width=650&height=150&src=pr&token=qJrryhpk7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/grails-core/pull/16669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@             Coverage Diff             @@
   ##             10.0.x     #16669   +/-   ##
   ===========================================
     Coverage          ?   63.7820%           
     Complexity        ?      28269           
   ===========================================
     Files             ?       2260           
     Lines             ?     112201           
     Branches          ?      20361           
   ===========================================
     Hits              ?      71564           
     Misses            ?      31488           
     Partials          ?       9149           
   ```
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Set the 10.0.x branch version to 10.0.0-SNAPSHOT and githubBranch to 10.0.x [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16669:
URL: https://github.com/apache/grails-core/pull/16669#issuecomment-6250691048

   ## 🚨 TestLens detected 1 failed test 🚨
   
   ### Test Summary
   > [!TIP]
   > Inspect all details with the [TestLens CLI](https://testlens.app/docs/features/cli): `testlens pr 16669`
   
   #### [CI / Build Grails-Core \(Windows JDK 25 shard 2\)](https://github.com/apache/grails-core/actions/runs/39132590538/job/117690616744?pr=16669) > :grails-core-cli-legacy:test
   
   | Test | Runs | Flakiness |
   |---|---|--:|
   | FileSystemInteractionImplSpec > files that do not exist yet are resolved like existing ones | ❌ | [6%&nbsp;🟠](https://github.com/apache/grails-core/issues/16030) |
   
   🏷️ Commit: fb8ecf06f84a20e9b90f7f5e37c03ed292614257
   ▶️ Tests:  7731 executed
   🟡 Checks: 20/82 completed
   
   ### Test Failures
   
   <details><summary><strong>FileSystemInteractionImplSpec > files that do not exist yet are resolved like existing ones</strong> (:grails-core-cli-legacy:test in <a href="https://github.com/apache/grails-core/actions/runs/39132590538/job/117690616744?pr=16669">CI / Build Grails-Core (Windows JDK 25 shard 2)</a>)</summary>
   
   ```
   Condition not satisfied:
   
   interaction.projectPath(missing) == 'nested/missing.txt'
   |           |           |        |
   |           |           |        false
   |           |           |        1 difference (94% similarity)
   |           |           |        nested(\\)missing.txt
   |           |           |        nested(/~)missing.txt
   |           |           C:\Users\RUNNER~1\AppData\Local\Temp\spock_files_that_do_not_e_0_directory2767243687461919963\nested\missing.txt
   |           nested\missing.txt
   <grails.dev.commands.io.FileSystemInteractionImpl@6a8a54f5 baseDir=C:\Users\RUNNER~1\AppData\Local\Temp\spock_files_that_do_not_e_0_directory2767243687461919963 resourceLoader=org.grails.io.support.DefaultResourceLoader@4623c0d3 resourcePatternResolver=org.grails.io.support.PathMatchingResourcePatternResolver@50fd4246 resourceLocator=org.grails.io.support.ResourceLocator@307cf289>
   
   	at grails.dev.commands.io.FileSystemInteractionImplSpec.files that do not exist yet are resolved like existing ones(FileSystemInteractionImplSpec.groovy:69)
   ```
   
   |expected|actual|
   |---|---|
   |nested<s>/</s>missing.txt|nested<b>\\</b>missing.txt|
   
   </details>
   
   ### Rerun Controls
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 FileSystemInteractionImplSpec > files that do not exist yet are resolved like existing ones <!-- uniqueId=[engine:spock]/[spec:grails.dev.commands.io.FileSystemInteractionImplSpec]/[feature:$spock_feature_0_1] -->
   
   Reuse successful test results:
   
   🔲 ♻️ Only rerun the tests that failed or were muted before
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Set the 10.0.x branch version to 10.0.0-SNAPSHOT and githubBranch to 10.0.x [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #16669:
URL: https://github.com/apache/grails-core/pull/16669


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org