[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #5443: PUT users/{id} endpoint has incorrect use of COALESCE for field new_user

[GitBox <gi...@apache.org>]

mitchell852 edited a comment on issue #5443:
URL: https://github.com/apache/trafficcontrol/issues/5443#issuecomment-761213952


   > I think the purpose of the `new_user` field is to cause TP to prompt them to change/set their password on login. The intention is that if that hasn't yet occurred, then the user is still "new". If someone else updates the user object e.g. because they realized the user needs to be in a higher tenant before the user completes registration, then it won't properly prompt then on their first login if you make this change. I think the behavior is currently working as intended, roughly. The only thing is that _any_ update through `user/current` is unsetting that field, when really I think it should only count password updates. But that's just my opinion.
   
   yep, @ocket8888 is right. new_user only gets set to false via PUT /users/current because when the user is updating their own user (and hopefully setting a username/pass), they are no longer "new". a very hacky solution but it was it is...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org