You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by John Roesler <jo...@confluent.io> on 2018/06/25 21:56:32 UTC
[VOTE] KIP-319: Replace numSegments to segmentInterval in Streams
window configurations
Hello All,
Thanks for the discussion on KIP-319. I'd now like to start the voting.
As a reminder, KIP-319 proposes a fix to an issue I identified in
KAFKA-7080. Specifically, the issue is that we're creating
CachingWindowStore with the *number of segments* instead of the *segment
size*.
Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080
Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ
Additionally, here's a draft PR for clarity:
https://github.com/apache/kafka/pull/5257
Thanks,
-John
Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams
window configurations
Posted by John Roesler <jo...@confluent.io>.
Thanks for voting, everyone.
KIP-319 has passed with 3 binding (Guozhang, Matthias, Damian) and 3
non-binding votes (Ted, Bill, and me!).
If you wish to review the implementation, I plan to build on the draft PR:
https://github.com/apache/kafka/pull/5257
Thanks again,
-John
On Thu, Jun 28, 2018 at 4:33 AM Damian Guy <da...@gmail.com> wrote:
> +1
>
> On Tue, 26 Jun 2018 at 17:22 Bill Bejeck <bb...@gmail.com> wrote:
>
> > +1
> >
> > On Mon, Jun 25, 2018 at 11:07 PM Matthias J. Sax <ma...@confluent.io>
> > wrote:
> >
> > > +1 (binding)
> > >
> > > On 6/25/18 3:00 PM, Guozhang Wang wrote:
> > > > +1
> > > >
> > > > On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu <yu...@gmail.com> wrote:
> > > >
> > > >> +1
> > > >>
> > > >> On Mon, Jun 25, 2018 at 2:56 PM, John Roesler <jo...@confluent.io>
> > > wrote:
> > > >>
> > > >>> Hello All,
> > > >>>
> > > >>> Thanks for the discussion on KIP-319. I'd now like to start the
> > voting.
> > > >>>
> > > >>> As a reminder, KIP-319 proposes a fix to an issue I identified in
> > > >>> KAFKA-7080. Specifically, the issue is that we're creating
> > > >>> CachingWindowStore with the *number of segments* instead of the
> > > *segment
> > > >>> size*.
> > > >>>
> > > >>> Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080
> > > >>> Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ
> > > >>>
> > > >>> Additionally, here's a draft PR for clarity:
> > > >>> https://github.com/apache/kafka/pull/5257
> > > >>>
> > > >>> Thanks,
> > > >>> -John
> > > >>>
> > > >>
> > > >
> > > >
> > > >
> > >
> > >
> >
>
Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams
window configurations
Posted by Damian Guy <da...@gmail.com>.
+1
On Tue, 26 Jun 2018 at 17:22 Bill Bejeck <bb...@gmail.com> wrote:
> +1
>
> On Mon, Jun 25, 2018 at 11:07 PM Matthias J. Sax <ma...@confluent.io>
> wrote:
>
> > +1 (binding)
> >
> > On 6/25/18 3:00 PM, Guozhang Wang wrote:
> > > +1
> > >
> > > On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu <yu...@gmail.com> wrote:
> > >
> > >> +1
> > >>
> > >> On Mon, Jun 25, 2018 at 2:56 PM, John Roesler <jo...@confluent.io>
> > wrote:
> > >>
> > >>> Hello All,
> > >>>
> > >>> Thanks for the discussion on KIP-319. I'd now like to start the
> voting.
> > >>>
> > >>> As a reminder, KIP-319 proposes a fix to an issue I identified in
> > >>> KAFKA-7080. Specifically, the issue is that we're creating
> > >>> CachingWindowStore with the *number of segments* instead of the
> > *segment
> > >>> size*.
> > >>>
> > >>> Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080
> > >>> Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ
> > >>>
> > >>> Additionally, here's a draft PR for clarity:
> > >>> https://github.com/apache/kafka/pull/5257
> > >>>
> > >>> Thanks,
> > >>> -John
> > >>>
> > >>
> > >
> > >
> > >
> >
> >
>
Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams
window configurations
Posted by Bill Bejeck <bb...@gmail.com>.
+1
On Mon, Jun 25, 2018 at 11:07 PM Matthias J. Sax <ma...@confluent.io>
wrote:
> +1 (binding)
>
> On 6/25/18 3:00 PM, Guozhang Wang wrote:
> > +1
> >
> > On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu <yu...@gmail.com> wrote:
> >
> >> +1
> >>
> >> On Mon, Jun 25, 2018 at 2:56 PM, John Roesler <jo...@confluent.io>
> wrote:
> >>
> >>> Hello All,
> >>>
> >>> Thanks for the discussion on KIP-319. I'd now like to start the voting.
> >>>
> >>> As a reminder, KIP-319 proposes a fix to an issue I identified in
> >>> KAFKA-7080. Specifically, the issue is that we're creating
> >>> CachingWindowStore with the *number of segments* instead of the
> *segment
> >>> size*.
> >>>
> >>> Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080
> >>> Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ
> >>>
> >>> Additionally, here's a draft PR for clarity:
> >>> https://github.com/apache/kafka/pull/5257
> >>>
> >>> Thanks,
> >>> -John
> >>>
> >>
> >
> >
> >
>
>
Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams
window configurations
Posted by "Matthias J. Sax" <ma...@confluent.io>.
+1 (binding)
On 6/25/18 3:00 PM, Guozhang Wang wrote:
> +1
>
> On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu <yu...@gmail.com> wrote:
>
>> +1
>>
>> On Mon, Jun 25, 2018 at 2:56 PM, John Roesler <jo...@confluent.io> wrote:
>>
>>> Hello All,
>>>
>>> Thanks for the discussion on KIP-319. I'd now like to start the voting.
>>>
>>> As a reminder, KIP-319 proposes a fix to an issue I identified in
>>> KAFKA-7080. Specifically, the issue is that we're creating
>>> CachingWindowStore with the *number of segments* instead of the *segment
>>> size*.
>>>
>>> Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080
>>> Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ
>>>
>>> Additionally, here's a draft PR for clarity:
>>> https://github.com/apache/kafka/pull/5257
>>>
>>> Thanks,
>>> -John
>>>
>>
>
>
>
Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams
window configurations
Posted by Guozhang Wang <wa...@gmail.com>.
+1
On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu <yu...@gmail.com> wrote:
> +1
>
> On Mon, Jun 25, 2018 at 2:56 PM, John Roesler <jo...@confluent.io> wrote:
>
> > Hello All,
> >
> > Thanks for the discussion on KIP-319. I'd now like to start the voting.
> >
> > As a reminder, KIP-319 proposes a fix to an issue I identified in
> > KAFKA-7080. Specifically, the issue is that we're creating
> > CachingWindowStore with the *number of segments* instead of the *segment
> > size*.
> >
> > Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080
> > Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ
> >
> > Additionally, here's a draft PR for clarity:
> > https://github.com/apache/kafka/pull/5257
> >
> > Thanks,
> > -John
> >
>
--
-- Guozhang
Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams
window configurations
Posted by Ted Yu <yu...@gmail.com>.
+1
On Mon, Jun 25, 2018 at 2:56 PM, John Roesler <jo...@confluent.io> wrote:
> Hello All,
>
> Thanks for the discussion on KIP-319. I'd now like to start the voting.
>
> As a reminder, KIP-319 proposes a fix to an issue I identified in
> KAFKA-7080. Specifically, the issue is that we're creating
> CachingWindowStore with the *number of segments* instead of the *segment
> size*.
>
> Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080
> Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ
>
> Additionally, here's a draft PR for clarity:
> https://github.com/apache/kafka/pull/5257
>
> Thanks,
> -John
>