You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/09/02 09:14:02 UTC

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #164: JCRVLT-557 - Testcase for creation of nodes calculating different nod…

kwin commented on a change in pull request #164:
URL: https://github.com/apache/jackrabbit-filevault/pull/164#discussion_r700901453



##########
File path: vault-core/src/test/resources/test-packages/test_implicit_definition.zip/META-INF/vault/filter.xml
##########
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<workspaceFilter version="1.0">
+    <filter root="/testroot/myfolder"/>

Review comment:
       as `/testroot/myfolder` is contained in the package, the existing node in the repo is overwritten by an install. Since the package contents don't define a specific node type the default node type "nt:folder" is used. This is expected and is exactly the behaviour which was fixed by https://issues.apache.org/jira/browse/JCRVLT-142/https://issues.apache.org/jira/browse/JCRVLT-415. Why should the existing `nt:unstructured` node type being preserved here? IMHO the package is just incorrect!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org