You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/23 05:21:26 UTC

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7896: [Bugfix] Remove prequery properties from query_obj

mistercrunch commented on a change in pull request #7896: [Bugfix] Remove prequery properties from query_obj
URL: https://github.com/apache/incubator-superset/pull/7896#discussion_r306132757
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -61,10 +61,18 @@
 config = app.config
 metadata = Model.metadata  # pylint: disable=no-member
 
-SqlaQuery = namedtuple(
-    "SqlaQuery", ["sqla_query", "labels_expected", "extra_cache_keys"]
-)
-QueryStringExtended = namedtuple("QueryStringExtended", ["sql", "labels_expected"])
+
+class SqlaQuery(NamedTuple):
 
 Review comment:
   Oh wow, the new `NamedTuple` are so much better, always hated the way the old ones were delcared...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org