You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/02/08 08:01:21 UTC
Review Request: Added a general comment describing jsonurl.py and updated
the error handling of recursive key lookup to avoid printing the Python
"stack trace" when there is an exception (i.e., more becoming of a utility).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9376/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
See summary.
Diffs
-----
support/jsonurl.py 0d74b710fda507d64e899f76f55d3c698ae9886f
Diff: https://reviews.apache.org/r/9376/diff/
Testing
-------
Thanks,
Benjamin Hindman
Re: Review Request: Added a general comment describing jsonurl.py and
updated the error handling of recursive key lookup to avoid printing the
Python "stack trace" when there is an exception (i.e.,
more becoming of a utility).
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9376/#review16370
-----------------------------------------------------------
Ship it!
Two questions to think about in terms of becoming a utility:
-This is a very specific utility, seems like it may be better to have this read json from stdin, that way people can curl and pipe it in.
-This reminds me of _.pluck (from underscore.js), maybe a name like jsonpluck would be more descriptive (were we to pull out the url loading bit).
-Being a utility, do we want to remove the .py suffix? Akin to post-reviews.
- Ben Mahler
On Feb. 8, 2013, 7:01 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9376/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2013, 7:01 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/jsonurl.py 0d74b710fda507d64e899f76f55d3c698ae9886f
>
> Diff: https://reviews.apache.org/r/9376/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a general comment describing jsonurl.py and
updated the error handling of recursive key lookup to avoid printing the
Python "stack trace" when there is an exception (i.e.,
more becoming of a utility).
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9376/#review16341
-----------------------------------------------------------
Ship it!
Ship It!
- Chris Mattmann
On Feb. 8, 2013, 7:01 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9376/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2013, 7:01 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/jsonurl.py 0d74b710fda507d64e899f76f55d3c698ae9886f
>
> Diff: https://reviews.apache.org/r/9376/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a general comment describing jsonurl.py and
updated the error handling of recursive key lookup to avoid printing the
Python "stack trace" when there is an exception (i.e.,
more becoming of a utility).
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9376/#review16365
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 8, 2013, 7:01 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9376/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2013, 7:01 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/jsonurl.py 0d74b710fda507d64e899f76f55d3c698ae9886f
>
> Diff: https://reviews.apache.org/r/9376/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>