You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/27 22:38:50 UTC

[GitHub] [tvm] jwfromm opened a new pull request #7353: [Relay][Frontend][Onnx] Robustify Loop Importer

jwfromm opened a new pull request #7353:
URL: https://github.com/apache/tvm/pull/7353


   Although the loop importer in onnx works for simple cases, it had some issues for loops that output and accumulate tensors. This PR adds handling for both scalar and tensor outputs and corresponding tests. 
   
   Note that one issue encountered was that an injective schedule was applied to concatenate during compilation. Unfortunately, the concat in our loop has dynamic shapes which caused an invalid access in the schedule. This PR also includes a check to make sure that the shapes of concat's inputs are static before trying to vectorize.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #7353: [Relay][Frontend][Onnx] Robustify Loop Importer

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7353:
URL: https://github.com/apache/tvm/pull/7353


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #7353: [Relay][Frontend][Onnx] Robustify Loop Importer

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7353:
URL: https://github.com/apache/tvm/pull/7353#issuecomment-768791983


   thanks @jwfromm @mbrookhart 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org