You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by GitBox <gi...@apache.org> on 2020/11/15 01:11:04 UTC

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #446: [WW-5096] Fix StaticParametersInterceptor param overwrite

JCgH4164838Gh792C124B5 commented on pull request #446:
URL: https://github.com/apache/struts/pull/446#issuecomment-727290131


   Hi @lukaszlenart  and @akash5885 .
   
   It looks like the original code of `StaticParametersInterceptor` `addParametersToContext()` was doing the same operations if `overwrite` was `true `or `false`, just in reverse-order depending on the `boolean `value. I think that was what @akash5885 stated in the JIRA ?
   
   Did the different ordering of the old code blocks have any effect at all, or was the end result the same whether `overwrite` was `true` or `false` ?
   
   Is there a possibility for a manual test example or test case that clarifies how the original code was not working as intended, and how the updated code does ?
   
   I am not sure I am understanding the original problem correctly, so I figured I would ask.  😄 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org