[jira] Updated: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated classes

["Ryan McKinley (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-301:
-------------------------------

    Attachment: SOLR-301-ParamCleanup.patch

This patch makes all the 'interface' classes into interfaces and keeps the logic classes as classes

The params from SolrParams are moved to CommonParams.
deprecated DisMax logic is moved to the deprecated o.a.s.util.DisMaxParams class
Facet parameters from SolrParams are moved to FacetParams.java
core classes are all updated to use the clean classes

I'll wait for SOLR-258 to be committed, then without objection add this.

> Clean up param interface.  Leave deprecated options in deprecated classes
> -------------------------------------------------------------------------
>
>                 Key: SOLR-301
>                 URL: https://issues.apache.org/jira/browse/SOLR-301
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-301-ParamCleanup.patch
>
>
> In SOLR-135, we moved the parameter handling stuff to a new package: o.a.s.common.params and left @deprecated classes in the old location.
> Classes in the new package should not contain any deprecated options. 
> Aditionally, we should aim to seperate parameter manipulation logic (DefaultSolrParams, AppendedSolrParams, etc) from 'parameter' interface classes: 'HighlightParams', 'UpdateParams'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.