NMS-AMQP: Provider shouldn't sent transfer frames as settled when sender settled mode is unsettled

[Krzysztof <h4...@gmail.com>]

Hi,

There is a bug in the current implementation of NMS-AMQP (
https://issues.apache.org/jira/browse/AMQNET-608) that results in sending
transfer frames on sender link as settled even when sender settled mode
is Unsettled. This is against AMQP spec. There is at least one broker that
detaches the sender link when a non-persistent(settled) message is sent - I
believe it is Solace Broker. This particular scenario affects only messages
sent in a fire and forget manner.

One of the proposed solutions is to simply set settled flag to false for
all of the sent messages.
The other is to use different settled mode for the sender link, e.i. Mixed.
The third solution would involve implementing presettle policy in the same
way as there is implemented in qpid jms.

I'd love your advice on this.

Thanks,
Krzysztof Porebski