You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/05 13:30:49 UTC

[GitHub] [tvm] MasterJH5574 opened a new pull request #10498: [TIR] Fix Tensorization IR-Comparator for Annotations

MasterJH5574 opened a new pull request #10498:
URL: https://github.com/apache/tvm/pull/10498


   This PR fixes the way of comparison in which the tensorization IR-comparator deals with annotations.
   
   Prior to this PR, the comparator requires the annotation values from LHS and RHS to be exactly the same, which is, in fact, never possible. And this PR removes this comparison requirement (with a regression unit test).
   
   ```c++
   bool TensorizeComparator::CompareAnnotation(const std::pair<String, ObjectRef>& lhs,
                                               const std::pair<String, ObjectRef>& rhs) {
     if (lhs.first != rhs.first) return false;
     if (!lhs.second.same_as(rhs.second)) return false;  // <== The values would never be the same.
                                                         //     Thus this line should be removed.
     return VisitExpr(Downcast<PrimExpr>(lhs.second), Downcast<PrimExpr>(rhs.second));
   }
   ```
   
   cc @spectrometerHBH @vinx13 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #10498: [TIR] Fix Tensorization IR-Comparator for Annotations

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #10498:
URL: https://github.com/apache/tvm/pull/10498#issuecomment-1059851895


   Thanks! This is merged!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 merged pull request #10498: [TIR] Fix Tensorization IR-Comparator for Annotations

Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #10498:
URL: https://github.com/apache/tvm/pull/10498


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org