[GitHub] [flink] xintongsong commented on pull request #14647: [FLINK-20835] Implement FineGrainedSlotManager

[GitBox <gi...@apache.org>]

xintongsong commented on pull request #14647:
URL: https://github.com/apache/flink/pull/14647#issuecomment-768265430


   @zentol,
   I think the core differences are 1) as you said tracking resources per task executor and decide the TM to allocate slot accordingly, and 2) the abstraction of `ResourceAllocationStrategy` because we are targeting to support multiple fine grained allocation strategy based on this slot manager.
   
   In long term, I think there should be only one slot manager, with potentially customized strategies. Legacy `SlotManagerImpl` should be removed together with the slot request based protocol, and the `FineGrainedSlotManager` and `DeclarativeSlotManager` are indeed similar and likely to be unified.
   
   However, at the moment I'm in favor of keeping `FineGrainedSlotManager` independent from `DeclarativeSlotManager`. It should helps us to quickly deliver the feature, without considering how it should be unified with the `DeclarativeSlotManager`, and most importantly without worrying about breaking the default slot manager for changes needed by the fine grained resource management.
   
   Maybe we can revisit unifying the two slot managers after the features are stabilized.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org