You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/06/26 22:17:09 UTC
[kudu-CR] Add regression test for HIVE-19569
Hello Adar Dembo, Hao Hao, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10832
to review the following change.
Change subject: Add regression test for HIVE-19569
......................................................................
Add regression test for HIVE-19569
HIVE-19569 affects some versions of the Hive 3.x line, and it will break
our integration. This additional test case will alert us if our bundeled
Hive version becomes susceptible.
Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
---
M src/kudu/integration-tests/master_hms-itest.cc
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/10832/1
--
To view, visit http://gerrit.cloudera.org:8080/10832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
Gerrit-Change-Number: 10832
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add regression test for HIVE-19569
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10832 )
Change subject: Add regression test for HIVE-19569
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
Gerrit-Change-Number: 10832
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 28 Jun 2018 00:23:53 +0000
Gerrit-HasComments: No
[kudu-CR] Add regression test for HIVE-19569
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10832 )
Change subject: Add regression test for HIVE-19569
......................................................................
Add regression test for HIVE-19569
HIVE-19569 affects some versions of the Hive 3.x line, and it will break
our integration. This additional test case will alert us if our bundeled
Hive version becomes susceptible.
Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
Reviewed-on: http://gerrit.cloudera.org:8080/10832
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/master_hms-itest.cc
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
Gerrit-Change-Number: 10832
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add regression test for HIVE-19569
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10832
to look at the new patch set (#3).
Change subject: Add regression test for HIVE-19569
......................................................................
Add regression test for HIVE-19569
HIVE-19569 affects some versions of the Hive 3.x line, and it will break
our integration. This additional test case will alert us if our bundeled
Hive version becomes susceptible.
Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
---
M src/kudu/integration-tests/master_hms-itest.cc
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/10832/3
--
To view, visit http://gerrit.cloudera.org:8080/10832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
Gerrit-Change-Number: 10832
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add regression test for HIVE-19569
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10832 )
Change subject: Add regression test for HIVE-19569
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10832/2/src/kudu/integration-tests/master_hms-itest.cc
File src/kudu/integration-tests/master_hms-itest.cc:
http://gerrit.cloudera.org:8080/#/c/10832/2/src/kudu/integration-tests/master_hms-itest.cc@334
PS2, Line 334: // Regression test for HIVE-19569
Could you add one sentence about what from below is expected to fail if the HMS instance being used is vulnerable to HIVE-19569? It isn't obvious from a cursory read of that bug report.
--
To view, visit http://gerrit.cloudera.org:8080/10832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
Gerrit-Change-Number: 10832
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 27 Jun 2018 22:52:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add regression test for HIVE-19569
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10832 )
Change subject: Add regression test for HIVE-19569
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10832/2/src/kudu/integration-tests/master_hms-itest.cc
File src/kudu/integration-tests/master_hms-itest.cc:
http://gerrit.cloudera.org:8080/#/c/10832/2/src/kudu/integration-tests/master_hms-itest.cc@334
PS2, Line 334: ASSERT_OK(CreateDatabase("db1"));
> Could you add one sentence about what from below is expected to fail if the
Done
--
To view, visit http://gerrit.cloudera.org:8080/10832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
Gerrit-Change-Number: 10832
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 27 Jun 2018 23:54:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add regression test for HIVE-19569
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10832 )
Change subject: Add regression test for HIVE-19569
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I560c65c9f56ed64fd13897951d2a719abb5c066b
Gerrit-Change-Number: 10832
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Jun 2018 23:39:44 +0000
Gerrit-HasComments: No