You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/02/04 10:35:45 UTC
[GitHub] [libcloud] Kami opened a new pull request #1421: Add support for
certificate and static token authentication to the Kubernetes driver
Kami opened a new pull request #1421: Add support for certificate and static token authentication to the Kubernetes driver
URL: https://github.com/apache/libcloud/pull/1421
This pull request updates Kubernetes container driver so it now also supports client side certificate and static bearer token authentication
## Background
Previously the driver only supported HTTP basic auth which is now deprecated.
## Implementation Details
Most of the code for handling various types of authentication mechanism was already there (either available in the Kubernetes container driver or the KubeVirt compute one),
this PR just updates it to make it more re-usable.
This way we avoid duplicated (copy and pasted) code and re-use those base connection classes by both of the Kubernetes driver.
## Testing
I tested the Kubernetes container driver and KubeVirt compute driver against a local minikube deployment.
It probably wouldn't hurt if KubeVirt one gets more testing (cc @Eis-D-Z).
On that note, for compliance with the base API (I missed that during the review), ``token_bearer_auth`` KubeVirt driver constructor argument has been renamed to ``ex_token_bearer_auth``.
## TODO
- [ ] Refactor auth classes tests and also use them with the KubeVirt compute driver tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1421: Add support for
certificate and static token authentication to the Kubernetes driver
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1421: Add support for certificate and static token authentication to the Kubernetes driver
URL: https://github.com/apache/libcloud/pull/1421#issuecomment-582158355
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1421?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`trunk@72bfabd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `96%`.
[](https://codecov.io/gh/apache/libcloud/pull/1421?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1421 +/- ##
========================================
Coverage ? 86.08%
========================================
Files ? 370
Lines ? 77495
Branches ? 7655
========================================
Hits ? 66710
Misses ? 7885
Partials ? 2900
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1421?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/common/base.py](https://codecov.io/gh/apache/libcloud/pull/1421/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tbW9uL2Jhc2UucHk=) | `90.48% <ø> (ø)` | |
| [libcloud/test/storage/test\_google\_storage.py](https://codecov.io/gh/apache/libcloud/pull/1421/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfZ29vZ2xlX3N0b3JhZ2UucHk=) | `97.04% <ø> (ø)` | |
| [libcloud/storage/drivers/google\_storage.py](https://codecov.io/gh/apache/libcloud/pull/1421/diff?src=pr&el=tree#diff-bGliY2xvdWQvc3RvcmFnZS9kcml2ZXJzL2dvb2dsZV9zdG9yYWdlLnB5) | `90.78% <100%> (ø)` | |
| [libcloud/test/common/test\_kubernetes.py](https://codecov.io/gh/apache/libcloud/pull/1421/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9rdWJlcm5ldGVzLnB5) | `100% <100%> (ø)` | |
| [libcloud/common/kubernetes.py](https://codecov.io/gh/apache/libcloud/pull/1421/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tbW9uL2t1YmVybmV0ZXMucHk=) | `80.8% <93.33%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1421?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1421?src=pr&el=footer). Last update [72bfabd...d72f000](https://codecov.io/gh/apache/libcloud/pull/1421?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1421: Add support for
certificate and static token authentication to the Kubernetes driver
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1421: Add support for certificate and static token authentication to the Kubernetes driver
URL: https://github.com/apache/libcloud/pull/1421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services