You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/08/25 02:30:55 UTC

Review Request 37740: Use zookeeperd package in vagrant.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37740/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
-------

Realized the `zookeeperd` package can stand in for our ucstom upstart script.  No other changes necessary.


Diffs
-----

  examples/vagrant/provision-dev-cluster.sh 16ae8d141a4fb8d7a76d5d9aaa2d44b38cf34bfa 
  examples/vagrant/upstart/zookeeper.conf fbc0a7983fe0124f86d214ef82bc40184995db81 

Diff: https://reviews.apache.org/r/37740/diff/


Testing
-------

e2e tests pass


Thanks,

Bill Farner

Re: Review Request 37740: Use zookeeperd package in vagrant.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37740/
-----------------------------------------------------------

(Updated Aug. 25, 2015, 12:56 a.m.)


Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description (updated)
-------

Realized the `zookeeperd` package can stand in for our custom upstart script.  No other changes necessary.


Diffs
-----

  examples/vagrant/provision-dev-cluster.sh 16ae8d141a4fb8d7a76d5d9aaa2d44b38cf34bfa 
  examples/vagrant/upstart/zookeeper.conf fbc0a7983fe0124f86d214ef82bc40184995db81 

Diff: https://reviews.apache.org/r/37740/diff/


Testing
-------

e2e tests pass


Thanks,

Bill Farner

Re: Review Request 37740: Use zookeeperd package in vagrant.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37740/#review96257
-----------------------------------------------------------

Ship it!


That's pretty neat!

- Maxim Khutornenko


On Aug. 25, 2015, 12:30 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37740/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 12:30 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Realized the `zookeeperd` package can stand in for our ucstom upstart script.  No other changes necessary.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/provision-dev-cluster.sh 16ae8d141a4fb8d7a76d5d9aaa2d44b38cf34bfa 
>   examples/vagrant/upstart/zookeeper.conf fbc0a7983fe0124f86d214ef82bc40184995db81 
> 
> Diff: https://reviews.apache.org/r/37740/diff/
> 
> 
> Testing
> -------
> 
> e2e tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>