You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2019/02/06 12:52:21 UTC

svn commit: r1853070 - /ofbiz/ofbiz-framework/trunk/applications/product/template/category/EditCategoryProducts.ftl

Author: jleroux
Date: Wed Feb  6 12:52:20 2019
New Revision: 1853070

URL: http://svn.apache.org/viewvc?rev=1853070&view=rev
Log:
Fixed: URL not encoding in FTL 
(OFBIZ-10816)

I have created Product as TEST#01 in demo site and attached the Same to category 
101. In the category master searched for category 101 went to product tab, when 
I am trying to open a product master, link is generated like and asking for 
creating new product. But in product search and menu click is working fine 
problem is from ftl url are not getting encoded...Don`t know whats happening on 
FTL printing.... 

jleroux: fixes also catalog/control/EditProduct?productId=test%2301 (for test#1)

Thanks: Murugeswari for report and Pawan Verma for the fix

Modified:
    ofbiz/ofbiz-framework/trunk/applications/product/template/category/EditCategoryProducts.ftl

Modified: ofbiz/ofbiz-framework/trunk/applications/product/template/category/EditCategoryProducts.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/template/category/EditCategoryProducts.ftl?rev=1853070&r1=1853069&r2=1853070&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/template/category/EditCategoryProducts.ftl (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/template/category/EditCategoryProducts.ftl Wed Feb  6 12:52:20 2019
@@ -74,10 +74,11 @@ under the License.
                 <#if productCategoryMember.thruDate?? && nowTimestamp.after(productCategoryMember.getTimestamp("thruDate"))><#assign hasExpired = true></#if>
                   <tr valign="middle"<#if "1" == rowClass> class="alternate-row"</#if>>
                     <td>
+                      <#assign parametersMap = Static['org.apache.ofbiz.base.util.UtilHttp'].urlEncodeArgs(Static['org.apache.ofbiz.base.util.UtilMisc'].toMap('productId', productCategoryMember.productId!))/>
                       <#if (product.smallImageUrl)??>
-                         <a href="<@o...@ofbizUrl>"><img alt="Small Image" src="<@o...@ofbizContentUrl>" class="cssImgSmall" align="middle" /></a>
+                        <a href="<@o...@ofbizUrl>"><img alt="Small Image" src="<@o...@ofbizContentUrl>" class="cssImgSmall" align="middle" /></a>
                       </#if>
-                      <a href="<@o...@ofbizUrl>" class="buttontext"><#if product??>${(product.internalName)!}</#if> [${(productCategoryMember.productId)!}]</a>
+                      <a href="<@o...@ofbizUrl>" class="buttontext"><#if product??>${(product.internalName)!}</#if> [${(productCategoryMember.productId)!}]</a>
                     </td>
                     <td <#if hasntStarted> style="color: red;"</#if>>${(productCategoryMember.fromDate)!}</td>
                     <td align="center">