You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by nonstop-qfchen <gi...@git.apache.org> on 2015/10/23 19:36:53 UTC
[GitHub] incubator-trafodion pull request: fix TRAFODION-1555
GitHub user nonstop-qfchen opened a pull request:
https://github.com/apache/incubator-trafodion/pull/144
fix TRAFODION-1555
Please refer to JIRA1555 for resolution details. Thanks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nonstop-qfchen/incubator-trafodion MDAMfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #144
----
commit 9937f92f6d8c11849f661db84262977b4409a21c
Author: Qifan Chen <qf...@dev02.trafodion.org>
Date: 2015-10-23T17:34:43Z
fix TRAFODION-1555
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: fix TRAFODION-1555
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/144#discussion_r42893715
--- Diff: core/sql/optimizer/ScanOptimizer.cpp ---
@@ -8590,6 +8595,7 @@ void MDAMCostWA::compute()
// // invalidate the cache
// disjunctsFR_.reset();
// disjunctsLR_.reset();
+ MDAM_DEBUG0(MTL2, "Mdam scan lost due to exceeding cost bound");
--- End diff --
I LOVE this kind of debugging aid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: fix TRAFODION-1555
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/144#discussion_r42893895
--- Diff: core/sql/optimizer/ScanOptimizer.cpp ---
@@ -8703,11 +8713,14 @@ void MDAMCostWA::computeDisjunct()
if(CURRSTMT_OPTDEFAULTS->indexEliminationLevel() != OptDefaults::MINIMUM
&& (!mdamForced_)
&& (CmpCommon::getDefault(RANGESPEC_TRANSFORMATION) == DF_ON )
+ && (CmpCommon::getDefault(MDAM_APPLY_RESTRICTION_CHECK) == DF_ON )
--- End diff --
The effect of this change is that we will pick MDAM more often? I take it the method "checkMDAMadditionalRestriction" is where the problem was?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: fix TRAFODION-1555
Posted by nonstop-qfchen <gi...@git.apache.org>.
Github user nonstop-qfchen commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/144#discussion_r42894168
--- Diff: core/sql/optimizer/ScanOptimizer.cpp ---
@@ -8703,11 +8713,14 @@ void MDAMCostWA::computeDisjunct()
if(CURRSTMT_OPTDEFAULTS->indexEliminationLevel() != OptDefaults::MINIMUM
&& (!mdamForced_)
&& (CmpCommon::getDefault(RANGESPEC_TRANSFORMATION) == DF_ON )
+ && (CmpCommon::getDefault(MDAM_APPLY_RESTRICTION_CHECK) == DF_ON )
--- End diff --
Yes, the costing is much better and we should trust it more :-).
On Fri, Oct 23, 2015 at 12:50 PM, DaveBirdsall <no...@github.com>
wrote:
> In core/sql/optimizer/ScanOptimizer.cpp
> <https://github.com/apache/incubator-trafodion/pull/144#discussion_r42893895>
> :
>
> > @@ -8703,11 +8713,14 @@ void MDAMCostWA::computeDisjunct()
> > if(CURRSTMT_OPTDEFAULTS->indexEliminationLevel() != OptDefaults::MINIMUM
> > && (!mdamForced_)
> > && (CmpCommon::getDefault(RANGESPEC_TRANSFORMATION) == DF_ON )
> > + && (CmpCommon::getDefault(MDAM_APPLY_RESTRICTION_CHECK) == DF_ON )
>
> The effect of this change is that we will pick MDAM more often? I take it
> the method "checkMDAMadditionalRestriction" is where the problem was?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-trafodion/pull/144/files#r42893895>.
>
--
Regards, --Qifan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: fix TRAFODION-1555
Posted by nonstop-qfchen <gi...@git.apache.org>.
Github user nonstop-qfchen commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/144#discussion_r42894238
--- Diff: core/sql/optimizer/ScanOptimizer.cpp ---
@@ -8590,6 +8595,7 @@ void MDAMCostWA::compute()
// // invalidate the cache
// disjunctsFR_.reset();
// disjunctsLR_.reset();
+ MDAM_DEBUG0(MTL2, "Mdam scan lost due to exceeding cost bound");
--- End diff --
Yes, these debug messages can help with narrow down the problem quickly.
On Fri, Oct 23, 2015 at 12:48 PM, DaveBirdsall <no...@github.com>
wrote:
> In core/sql/optimizer/ScanOptimizer.cpp
> <https://github.com/apache/incubator-trafodion/pull/144#discussion_r42893715>
> :
>
> > @@ -8590,6 +8595,7 @@ void MDAMCostWA::compute()
> > // // invalidate the cache
> > // disjunctsFR_.reset();
> > // disjunctsLR_.reset();
> > + MDAM_DEBUG0(MTL2, "Mdam scan lost due to exceeding cost bound");
>
> I LOVE this kind of debugging aid.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-trafodion/pull/144/files#r42893715>.
>
--
Regards, --Qifan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: fix TRAFODION-1555
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---