You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by wl...@apache.org on 2020/04/16 06:16:40 UTC
[rocketmq] branch develop updated: fixed typo in
RequestResponseFuture. rename RequestResponseFuture.setSendReqeustOk to
RequestResponseFuture.setSendRequestOk.
This is an automated email from the ASF dual-hosted git repository.
wlliqipeng pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 78b6d7b fixed typo in RequestResponseFuture. rename RequestResponseFuture.setSendReqeustOk to RequestResponseFuture.setSendRequestOk.
new 1706cec Merge pull request #1941 from ifplusor/fixed-typo-in-RequestResponseFuture
78b6d7b is described below
commit 78b6d7b5bb128b0d4ad80f2814e228485d3b8c15
Author: James Yin <yw...@hotmail.com>
AuthorDate: Wed Apr 15 11:42:51 2020 +0800
fixed typo in RequestResponseFuture.
rename RequestResponseFuture.setSendReqeustOk to
RequestResponseFuture.setSendRequestOk.
---
.../client/impl/producer/DefaultMQProducerImpl.java | 20 ++++++++++----------
.../client/producer/RequestResponseFuture.java | 4 ++--
.../client/producer/DefaultMQProducerTest.java | 2 +-
.../client/producer/RequestResponseFutureTest.java | 2 +-
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
index fca50cc..2f171ae 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
@@ -1356,12 +1356,12 @@ public class DefaultMQProducerImpl implements MQProducerInner {
this.sendDefaultImpl(msg, CommunicationMode.ASYNC, new SendCallback() {
@Override
public void onSuccess(SendResult sendResult) {
- requestResponseFuture.setSendReqeustOk(true);
+ requestResponseFuture.setSendRequestOk(true);
}
@Override
public void onException(Throwable e) {
- requestResponseFuture.setSendReqeustOk(false);
+ requestResponseFuture.setSendRequestOk(false);
requestResponseFuture.putResponseMessage(null);
requestResponseFuture.setCause(e);
}
@@ -1395,7 +1395,7 @@ public class DefaultMQProducerImpl implements MQProducerInner {
this.sendDefaultImpl(msg, CommunicationMode.ASYNC, new SendCallback() {
@Override
public void onSuccess(SendResult sendResult) {
- requestResponseFuture.setSendReqeustOk(true);
+ requestResponseFuture.setSendRequestOk(true);
}
@Override
@@ -1421,12 +1421,12 @@ public class DefaultMQProducerImpl implements MQProducerInner {
this.sendSelectImpl(msg, selector, arg, CommunicationMode.ASYNC, new SendCallback() {
@Override
public void onSuccess(SendResult sendResult) {
- requestResponseFuture.setSendReqeustOk(true);
+ requestResponseFuture.setSendRequestOk(true);
}
@Override
public void onException(Throwable e) {
- requestResponseFuture.setSendReqeustOk(false);
+ requestResponseFuture.setSendRequestOk(false);
requestResponseFuture.putResponseMessage(null);
requestResponseFuture.setCause(e);
}
@@ -1461,7 +1461,7 @@ public class DefaultMQProducerImpl implements MQProducerInner {
this.sendSelectImpl(msg, selector, arg, CommunicationMode.ASYNC, new SendCallback() {
@Override
public void onSuccess(SendResult sendResult) {
- requestResponseFuture.setSendReqeustOk(true);
+ requestResponseFuture.setSendRequestOk(true);
}
@Override
@@ -1487,12 +1487,12 @@ public class DefaultMQProducerImpl implements MQProducerInner {
this.sendKernelImpl(msg, mq, CommunicationMode.ASYNC, new SendCallback() {
@Override
public void onSuccess(SendResult sendResult) {
- requestResponseFuture.setSendReqeustOk(true);
+ requestResponseFuture.setSendRequestOk(true);
}
@Override
public void onException(Throwable e) {
- requestResponseFuture.setSendReqeustOk(false);
+ requestResponseFuture.setSendRequestOk(false);
requestResponseFuture.putResponseMessage(null);
requestResponseFuture.setCause(e);
}
@@ -1526,7 +1526,7 @@ public class DefaultMQProducerImpl implements MQProducerInner {
this.sendKernelImpl(msg, mq, CommunicationMode.ASYNC, new SendCallback() {
@Override
public void onSuccess(SendResult sendResult) {
- requestResponseFuture.setSendReqeustOk(true);
+ requestResponseFuture.setSendRequestOk(true);
}
@Override
@@ -1540,7 +1540,7 @@ public class DefaultMQProducerImpl implements MQProducerInner {
private void requestFail(final String correlationId) {
RequestResponseFuture responseFuture = RequestFutureTable.getRequestFutureTable().remove(correlationId);
if (responseFuture != null) {
- responseFuture.setSendReqeustOk(false);
+ responseFuture.setSendRequestOk(false);
responseFuture.putResponseMessage(null);
try {
responseFuture.executeRequestCallback();
diff --git a/client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java b/client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java
index c54b236..e66c08f 100644
--- a/client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java
+++ b/client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java
@@ -103,8 +103,8 @@ public class RequestResponseFuture {
return sendRequestOk;
}
- public void setSendReqeustOk(boolean sendReqeustOk) {
- this.sendRequestOk = sendReqeustOk;
+ public void setSendRequestOk(boolean sendRequestOk) {
+ this.sendRequestOk = sendRequestOk;
}
public Message getRequestMsg() {
diff --git a/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java b/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java
index d572a23..41046fc 100644
--- a/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java
+++ b/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java
@@ -373,7 +373,7 @@ public class DefaultMQProducerTest {
assertThat(responseMap).isNotNull();
for (Map.Entry<String, RequestResponseFuture> entry : responseMap.entrySet()) {
RequestResponseFuture future = entry.getValue();
- future.setSendReqeustOk(true);
+ future.setSendRequestOk(true);
message.setFlag(1);
future.getRequestCallback().onSuccess(message);
}
diff --git a/client/src/test/java/org/apache/rocketmq/client/producer/RequestResponseFutureTest.java b/client/src/test/java/org/apache/rocketmq/client/producer/RequestResponseFutureTest.java
index 90e4623..bc20873 100644
--- a/client/src/test/java/org/apache/rocketmq/client/producer/RequestResponseFutureTest.java
+++ b/client/src/test/java/org/apache/rocketmq/client/producer/RequestResponseFutureTest.java
@@ -37,7 +37,7 @@ public class RequestResponseFutureTest {
@Override public void onException(Throwable e) {
}
});
- future.setSendReqeustOk(true);
+ future.setSendRequestOk(true);
future.executeRequestCallback();
assertThat(cc.get()).isEqualTo(1);
}