Re: [PR] Fix nullptr crash in RecConfigOverrideFromEnvironment with runroot [trafficserver]

["zwoop (via GitHub)" <gi...@apache.org>]

zwoop commented on code in PR #12917:
URL: https://github.com/apache/trafficserver/pull/12917#discussion_r2880913333


##########
src/records/RecConfigParse.cc:
##########
@@ -123,7 +123,7 @@ RecConfigOverrideFromEnvironment(const char *name, const char *value)
   if (envval) {
     return envval;
   } else if (RecConfigOverrideFromRunroot(name)) {
-    return nullptr;

Review Comment:
   Why this else if ? you return "value" regardless of the value of RecConfigOverrideFromRunroot(name)), no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org