You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/17 02:48:26 UTC
[GitHub] [cloudstack] YunLemon opened a new pull request #5324: Improve Travis CI build Performance
YunLemon opened a new pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324
According to [Build times out because no output was received](https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received), we should carefully use travis_wait, as it may make the build unstable and extend the build time.
=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-911511311
Closing this, @YunLemon kindly re-open if we've further changes. I double-checked this change doesn't improve Travis run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-901032691
I think it was shear luck, travis_wait is used when/if builds take time and there are no logs so travis won't fail/kill such jobs (producing no outputs). Let me rekick travis to see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-909028334
Ping @YunLemon - can you review and make more changes or close this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-900763065
Thanks @YunLemon, interesting PR. I've noticed the `travis_wait` function has been used since the integration with Travis. Besides the documentation link in the PR description I have no other reference of this function to analyze its removal @rhtyd any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-901032691
I think it was shear luck, travis_wait is used when/if builds take time and there are no logs so travis won't fail/kill such jobs (producing no outputs). Let me rekick travis to see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-902633007
If you/we search we've had a discussion somewhere about this, I don't think removing the travis_wait benefits; instead removing it may cause failures if/when deploy datacenter or any smoketests takes time to run (i.e. does not output logs) - travis may kill the job. However, the timeout interval may be tuned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-909028334
Ping @YunLemon - can you review and make more changes or close this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-900517333
interesting @YunLemon , I see the travis run on this PR succeeded in one go.
@rhtyd @nvazquez I think we should give this a try. Travis is haunting us a lot and certainly the mvn commands are not without output so wouldn't need the travis_wait. The longer tests may be silent, but also not persisting much, so it wouldn't help much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-900763065
Thanks @YunLemon, interesting PR. I've noticed the `travis_wait` function has been used since the integration with Travis. Besides the documentation link in the PR description I have no other reference of this function to analyze its removal @rhtyd any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-902633007
If you/we search we've had a discussion somewhere about this, I don't think removing the travis_wait benefits; instead removing it may cause failures if/when deploy datacenter or any smoketests takes time to run (i.e. does not output logs) - travis may kill the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-900517333
interesting @YunLemon , I see the travis run on this PR succeeded in one go.
@rhtyd @nvazquez I think we should give this a try. Travis is haunting us a lot and certainly the mvn commands are not without output so wouldn't need the travis_wait. The longer tests may be silent, but also not persisting much, so it wouldn't help much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-902515110
I think https://app.travis-ci.com/github/apache/cloudstack/jobs/532528584 proves @rhtyd 's point @YunLemon . See the last line in the output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5324: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5324:
URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-909028334
Ping @YunLemon - can you review and make more changes or close this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org