You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/14 05:39:21 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #9525:
[WiP] Migrating shared NVD3 controls to new module
rusackas opened a new pull request #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [x] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Migrating controls that are ONLY used by NVD3 into a new shared module for use in that package.
If I find a control that has one or two other uses, I'll move it into the shared module AND the individual outlier plugin packages.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #9187
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/30916adc5938cdf28689bf9a5c6c53380f69eac4&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.42% 65.42%
=======================================
Files 574 574
Lines 29887 29887
Branches 3049 3049
=======================================
Hits 19555 19555
Misses 10148 10148
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #mysql | `70.08% <0.00%> (ø)` | |
| #postgres | `70.05% <0.00%> (ø)` | |
| #python | `70.17% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `65.42% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [30916ad...30916ad](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409893585
##########
File path: superset-frontend/src/utils/chartControlsInventory.js
##########
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import memoize from 'lodash/memoize';
+import { getChartControlPanelRegistry } from '@superset-ui/chart';
+import controls from '../explore/controls';
+
+const getControlsForVizType = memoize(vizType => {
Review comment:
or do we still need this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409268481
##########
File path: superset-frontend/src/explore/controlPanels/Bubble.js
##########
@@ -39,15 +72,22 @@ export default {
expanded: true,
controlSetRows: [
['color_scheme', 'label_colors'],
- ['show_legend', null],
+ [showLegend, null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'left_margin'],
- ['x_axis_format', 'x_ticks_layout'],
+ [xAxisLabel, leftMargin],
+ [
+ {
+ ...xAxisFormat,
Review comment:
Well, now, THAT is... just an old fashioned mistake. 🙈
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409267848
##########
File path: superset-frontend/src/explore/controlPanels/Area.js
##########
@@ -48,34 +62,30 @@ export default {
},
],
['color_scheme', 'label_colors'],
- ['rich_tooltip', 'show_controls'],
+ [richTooltip, showControls],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_ticks_layout', 'x_axis_format'],
- ['x_axis_showminmax', null],
+ [xAxisLabel, bottomMargin],
+ [xTicksLayout, xAxisFormat],
Review comment:
Effectively, yes. The majority of the `xAxisFormat` controls had the exact same overrides, so I made _that_ the default configuration whem moving it to `Shared_NVD3.js`, and instead added overrides the _other_ way. I figured the majority use case should be the default :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `51.06%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 65.43% 65.27% -0.16%
==========================================
Files 571 574 +3
Lines 29847 29887 +40
Branches 3040 3049 +9
==========================================
- Hits 19529 19510 -19
- Misses 10134 10193 +59
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <51.06%> (-0.03%)` | :arrow_down: |
| #mysql | `?` | |
| #python | `69.92% <ø> (-0.23%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `65.27% <51.06%> (-0.16%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.04% <0.00%> (-0.05%)` | :arrow_down: |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.82% <100.00%> (+0.13%)` | :arrow_up: |
| [...erset-frontend/src/utils/chartControlsInventory.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NoYXJ0Q29udHJvbHNJbnZlbnRvcnkuanM=) | `100.00% <100.00%> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [29bbc62...29bbc62](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409886414
##########
File path: superset-frontend/src/explore/controlPanels/Compare.js
##########
@@ -19,6 +19,18 @@
import { t } from '@superset-ui/translation';
import { NVD3TimeSeries, annotations } from './sections';
import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import {
+ xAxisLabel,
+ yAxisLabel,
+ bottomMargin,
+ xTicksLayout,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ leftMargin,
+} from './Shared_NVD3';
Review comment:
Perhaps use camelcase file naming `SharedNVD3`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/30916adc5938cdf28689bf9a5c6c53380f69eac4&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.38% 65.38%
=======================================
Files 574 574
Lines 29887 29887
Branches 3049 3049
=======================================
Hits 19543 19543
Misses 10160 10160
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #postgres | `70.05% <0.00%> (ø)` | |
| #python | `70.10% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `65.38% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [30916ad...30916ad](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409990512
##########
File path: superset-frontend/src/explore/controlPanels/Compare.js
##########
@@ -19,6 +19,18 @@
import { t } from '@superset-ui/translation';
import { NVD3TimeSeries, annotations } from './sections';
import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import {
+ xAxisLabel,
+ yAxisLabel,
+ bottomMargin,
+ xTicksLayout,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ leftMargin,
+} from './Shared_NVD3';
Review comment:
Hmm... I was just going for namespacing, even if temporary. RIght now there are:
`Shared_NVD3.js`
`Shared_DeckGL.jsx`
`Shared_BigNumber.js`
I imagine when we pull all this stuff into the individual packages, we can just call them all `SharedControls.js(x)`
If you'd like to get rid of the underscores in the interim (no strong feelings, here), I might rather just fix all three in a fast-follow PR after this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f40f012e3c4bb208f23912d2cd54d947a4feaeb1&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 70.14% 70.14%
=======================================
Files 182 182
Lines 17477 17477
=======================================
Hits 12260 12260
Misses 5217 5217
```
| Flag | Coverage Δ | |
|---|---|---|
| #mysql | `70.08% <0.00%> (ø)` | |
| #postgres | `70.05% <0.00%> (ø)` | |
| #python | `70.14% <0.00%> (ø)` | |
| #unittest | `70.14% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [f40f012...f40f012](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409994251
##########
File path: superset-frontend/src/explore/controlPanels/TimePivot.js
##########
@@ -17,47 +17,99 @@
* under the License.
*/
import { t } from '@superset-ui/translation';
-import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import { D3_FORMAT_OPTIONS } from '../controls';
+import {
+ lineInterpolation,
+ showLegend,
+ xAxisLabel,
+ bottomMargin,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ yAxisLabel,
+ leftMargin,
+} from './Shared_NVD3';
export default {
requiresTime: true,
controlPanelSections: [
{
label: t('Query'),
expanded: true,
- controlSetRows: [['metric'], ['adhoc_filters'], ['freq']],
+ controlSetRows: [
+ ['metric'],
+ ['adhoc_filters'],
+ [
+ {
+ name: 'freq',
+ config: {
+ type: 'SelectControl',
+ label: t('Frequency'),
+ default: 'W-MON',
+ freeForm: true,
+ clearable: false,
+ choices: [
+ ['AS', 'Year (freq=AS)'],
+ ['52W-MON', '52 weeks starting Monday (freq=52W-MON)'],
+ ['W-SUN', '1 week starting Sunday (freq=W-SUN)'],
+ ['W-MON', '1 week starting Monday (freq=W-MON)'],
+ ['D', 'Day (freq=D)'],
+ ['4W-MON', '4 weeks (freq=4W-MON)'],
+ ],
+ description: t(
+ `The periodicity over which to pivot time. Users can provide
+ "Pandas" offset alias.
+ Click on the info bubble for more details on accepted "freq" expressions.`,
+ ),
+ tooltipOnClick: () => {
+ window.open(
+ 'https://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases',
+ );
+ },
+ },
+ },
+ ],
+ ],
},
{
label: t('Chart Options'),
expanded: true,
controlSetRows: [
- ['show_legend', 'line_interpolation'],
+ [showLegend, lineInterpolation],
['color_picker', null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_axis_showminmax', 'x_axis_format'],
+ [xAxisLabel, bottomMargin],
+ [
+ xAxisShowMinmax,
+ {
Review comment:
I agree for any utility functions we introduce we should also consider whether it makes sense to expose to future plugin developers. Ideally there should be a straightforward public API with which developers can do most of what they want without the need of diving into the internals of the plugin system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `52.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 65.43% 65.42% -0.01%
==========================================
Files 571 574 +3
Lines 29847 29890 +43
Branches 3040 3052 +12
==========================================
+ Hits 19529 19557 +28
- Misses 10134 10149 +15
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <52.00%> (-0.03%)` | :arrow_down: |
| #mysql | `70.08% <ø> (ø)` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.17% <ø> (+0.03%)` | :arrow_up: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `65.42% <52.00%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | `27.77% <0.00%> (-1.64%)` | :arrow_down: |
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.04% <0.00%> (-0.05%)` | :arrow_down: |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.82% <100.00%> (+0.13%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/314eb2fc54693cdb1de3874dc61224e8608b9838&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.28% 65.28%
=======================================
Files 574 574
Lines 29889 29889
Branches 3052 3052
=======================================
Hits 19512 19512
Misses 10193 10193
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #python | `69.92% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `65.28% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/314eb2fc54693cdb1de3874dc61224e8608b9838&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.43% 65.43%
=======================================
Files 574 574
Lines 29889 29889
Branches 3052 3052
=======================================
Hits 19557 19557
Misses 10148 10148
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #mysql | `70.08% <0.00%> (ø)` | |
| #postgres | `70.05% <0.00%> (ø)` | |
| #python | `70.17% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `65.43% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409993191
##########
File path: superset-frontend/src/explore/controlPanels/TimePivot.js
##########
@@ -17,47 +17,99 @@
* under the License.
*/
import { t } from '@superset-ui/translation';
-import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import { D3_FORMAT_OPTIONS } from '../controls';
+import {
+ lineInterpolation,
+ showLegend,
+ xAxisLabel,
+ bottomMargin,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ yAxisLabel,
+ leftMargin,
+} from './Shared_NVD3';
export default {
requiresTime: true,
controlPanelSections: [
{
label: t('Query'),
expanded: true,
- controlSetRows: [['metric'], ['adhoc_filters'], ['freq']],
+ controlSetRows: [
+ ['metric'],
+ ['adhoc_filters'],
+ [
+ {
+ name: 'freq',
+ config: {
+ type: 'SelectControl',
+ label: t('Frequency'),
+ default: 'W-MON',
+ freeForm: true,
+ clearable: false,
+ choices: [
+ ['AS', 'Year (freq=AS)'],
+ ['52W-MON', '52 weeks starting Monday (freq=52W-MON)'],
+ ['W-SUN', '1 week starting Sunday (freq=W-SUN)'],
+ ['W-MON', '1 week starting Monday (freq=W-MON)'],
+ ['D', 'Day (freq=D)'],
+ ['4W-MON', '4 weeks (freq=4W-MON)'],
+ ],
+ description: t(
+ `The periodicity over which to pivot time. Users can provide
+ "Pandas" offset alias.
+ Click on the info bubble for more details on accepted "freq" expressions.`,
+ ),
+ tooltipOnClick: () => {
+ window.open(
+ 'https://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases',
+ );
+ },
+ },
+ },
+ ],
+ ],
},
{
label: t('Chart Options'),
expanded: true,
controlSetRows: [
- ['show_legend', 'line_interpolation'],
+ [showLegend, lineInterpolation],
['color_picker', null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_axis_showminmax', 'x_axis_format'],
+ [xAxisLabel, bottomMargin],
+ [
+ xAxisShowMinmax,
+ {
Review comment:
Good news is, it seems like we're down to this, and an easy fast-follow PR. Excited this one is almost behind us, and appreciative of your time/effort on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r410029457
##########
File path: superset-frontend/src/explore/controlPanels/TimePivot.js
##########
@@ -17,47 +17,99 @@
* under the License.
*/
import { t } from '@superset-ui/translation';
-import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import { D3_FORMAT_OPTIONS } from '../controls';
+import {
+ lineInterpolation,
+ showLegend,
+ xAxisLabel,
+ bottomMargin,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ yAxisLabel,
+ leftMargin,
+} from './Shared_NVD3';
export default {
requiresTime: true,
controlPanelSections: [
{
label: t('Query'),
expanded: true,
- controlSetRows: [['metric'], ['adhoc_filters'], ['freq']],
+ controlSetRows: [
+ ['metric'],
+ ['adhoc_filters'],
+ [
+ {
+ name: 'freq',
+ config: {
+ type: 'SelectControl',
+ label: t('Frequency'),
+ default: 'W-MON',
+ freeForm: true,
+ clearable: false,
+ choices: [
+ ['AS', 'Year (freq=AS)'],
+ ['52W-MON', '52 weeks starting Monday (freq=52W-MON)'],
+ ['W-SUN', '1 week starting Sunday (freq=W-SUN)'],
+ ['W-MON', '1 week starting Monday (freq=W-MON)'],
+ ['D', 'Day (freq=D)'],
+ ['4W-MON', '4 weeks (freq=4W-MON)'],
+ ],
+ description: t(
+ `The periodicity over which to pivot time. Users can provide
+ "Pandas" offset alias.
+ Click on the info bubble for more details on accepted "freq" expressions.`,
+ ),
+ tooltipOnClick: () => {
+ window.open(
+ 'https://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases',
+ );
+ },
+ },
+ },
+ ],
+ ],
},
{
label: t('Chart Options'),
expanded: true,
controlSetRows: [
- ['show_legend', 'line_interpolation'],
+ [showLegend, lineInterpolation],
['color_picker', null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_axis_showminmax', 'x_axis_format'],
+ [xAxisLabel, bottomMargin],
+ [
+ xAxisShowMinmax,
+ {
Review comment:
I don't feel that strongly about this one. Can drop.
My main intention was to start introducing type checking for the config.
Perhaps can revisit typing later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b4b0d1c610a3bd4a46f264b1a8e7d7f5656717d&el=desc) will **increase** coverage by `4.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.75% 70.10% +4.35%
==========================================
Files 569 182 -387
Lines 29501 17477 -12024
Branches 3040 0 -3040
==========================================
- Hits 19397 12253 -7144
+ Misses 9920 5224 -4696
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (-0.61%)` | :arrow_down: |
| #python | `70.10% <ø> (-0.69%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (-0.61%)` | :arrow_down: |
| #unittest | `70.10% <ø> (+4.35%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.40% <0.00%> (-7.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `79.74% <0.00%> (-6.52%)` | :arrow_down: |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.55% <0.00%> (-1.35%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-0.96%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.39% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [391 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [7b4b0d1...512928c](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/314eb2fc54693cdb1de3874dc61224e8608b9838&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 58.74% 58.74%
=======================================
Files 392 392
Lines 12412 12412
Branches 3052 3052
=======================================
Hits 7292 7292
Misses 4936 4936
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #unittest | `58.74% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409264299
##########
File path: superset-frontend/src/explore/controlPanels/Area.js
##########
@@ -48,34 +62,30 @@ export default {
},
],
['color_scheme', 'label_colors'],
- ['rich_tooltip', 'show_controls'],
+ [richTooltip, showControls],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_ticks_layout', 'x_axis_format'],
- ['x_axis_showminmax', null],
+ [xAxisLabel, bottomMargin],
+ [xTicksLayout, xAxisFormat],
Review comment:
Was the `controlOverrides` applied to `xAxisFormat`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `51.06%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 65.43% 65.38% -0.05%
==========================================
Files 571 574 +3
Lines 29847 29887 +40
Branches 3040 3049 +9
==========================================
+ Hits 19529 19543 +14
- Misses 10134 10160 +26
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <51.06%> (-0.03%)` | :arrow_down: |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.10% <ø> (-0.04%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `65.38% <51.06%> (-0.05%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.04% <0.00%> (-0.05%)` | :arrow_down: |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.82% <100.00%> (+0.13%)` | :arrow_up: |
| [...erset-frontend/src/utils/chartControlsInventory.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NoYXJ0Q29udHJvbHNJbnZlbnRvcnkuanM=) | `100.00% <100.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [29bbc62...29bbc62](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a8021ed07959981f41cae57938f769f85f4dfd32&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.58% 65.58%
=======================================
Files 574 574
Lines 30060 30060
Branches 3054 3054
=======================================
Hits 19714 19714
Misses 10162 10162
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <0.00%> (ø)` | |
| #python | `70.38% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [a8021ed...a8021ed](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/30916adc5938cdf28689bf9a5c6c53380f69eac4&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.38% 65.38%
=======================================
Files 574 574
Lines 29887 29887
Branches 3049 3049
=======================================
Hits 19543 19543
Misses 10160 10160
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #postgres | `70.05% <0.00%> (ø)` | |
| #python | `70.10% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `65.38% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [30916ad...30916ad](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **increase** coverage by `4.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.29% 69.92% +4.62%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19490 12220 -7270
+ Misses 10173 5257 -4916
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `69.92% <ø> (ø)` | |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `69.92% <ø> (+4.62%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/CRUD/Fieldset.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGRzZXQuanN4) | | |
| [...set-frontend/src/dashboard/util/getLocationHash.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExvY2F0aW9uSGFzaC5qcw==) | | |
| [superset-frontend/src/components/Menu/NewMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LmpzeA==) | | |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | | |
| [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | | |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | | |
| [...hboard/components/menu/BackgroundStyleDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvQmFja2dyb3VuZFN0eWxlRHJvcGRvd24uanN4) | | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | | |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | | |
| [superset-frontend/src/components/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT25QYXN0ZVNlbGVjdC5qc3g=) | | |
| ... and [373 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [08e10b4...08e10b4](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **increase** coverage by `4.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.43% 70.10% +4.67%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19529 12253 -7276
+ Misses 10134 5224 -4910
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.10% <ø> (-0.04%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `70.10% <ø> (+4.67%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | | |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | |
| [...nd/src/messageToasts/containers/ToastPresenter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29udGFpbmVycy9Ub2FzdFByZXNlbnRlci5qc3g=) | | |
| [...nd/src/messageToasts/components/ToastPresenter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdFByZXNlbnRlci5qc3g=) | | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | | |
| ... and [376 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [30916ad...30916ad](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409269108
##########
File path: superset-frontend/src/explore/controlPanels/TimePivot.js
##########
@@ -17,47 +17,96 @@
* under the License.
*/
import { t } from '@superset-ui/translation';
-import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import { D3_FORMAT_OPTIONS } from '../controls';
+import {
+ lineInterpolation,
+ showLegend,
+ xAxisLabel,
+ bottomMargin,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ yAxisLabel,
+ leftMargin,
+} from './Shared_NVD3';
export default {
requiresTime: true,
controlPanelSections: [
{
label: t('Query'),
expanded: true,
- controlSetRows: [['metric'], ['adhoc_filters'], ['freq']],
+ controlSetRows: [
+ ['metric'],
+ ['adhoc_filters'],
+ [
+ {
+ name: 'freq',
+ config: {
+ type: 'SelectControl',
+ label: t('Frequency'),
+ default: 'W-MON',
+ freeForm: true,
+ clearable: false,
+ choices: [
+ ['AS', 'Year (freq=AS)'],
+ ['52W-MON', '52 weeks starting Monday (freq=52W-MON)'],
+ ['W-SUN', '1 week starting Sunday (freq=W-SUN)'],
+ ['W-MON', '1 week starting Monday (freq=W-MON)'],
+ ['D', 'Day (freq=D)'],
+ ['4W-MON', '4 weeks (freq=4W-MON)'],
+ ],
+ description: t(
+ `The periodicity over which to pivot time. Users can provide
+ "Pandas" offset alias.
+ Click on the info bubble for more details on accepted "freq" expressions.`,
+ ),
+ tooltipOnClick: () => {
+ window.open(
+ 'https://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases',
+ );
+ },
+ },
+ },
+ ],
+ ],
},
{
label: t('Chart Options'),
expanded: true,
controlSetRows: [
- ['show_legend', 'line_interpolation'],
+ [showLegend, lineInterpolation],
['color_picker', null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_axis_showminmax', 'x_axis_format'],
+ [xAxisLabel, bottomMargin],
+ [
+ xAxisShowMinmax,
+ {
+ ...xAxisFormat,
Review comment:
Same goof here... will fix 😧
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b4b0d1c610a3bd4a46f264b1a8e7d7f5656717d&el=desc) will **increase** coverage by `4.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.75% 70.14% +4.39%
==========================================
Files 569 182 -387
Lines 29501 17477 -12024
Branches 3040 0 -3040
==========================================
- Hits 19397 12260 -7137
+ Misses 9920 5217 -4703
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `70.08% <ø> (-0.61%)` | :arrow_down: |
| #postgres | `70.05% <ø> (-0.61%)` | :arrow_down: |
| #python | `70.14% <ø> (-0.65%)` | :arrow_down: |
| #sqlite | `?` | |
| #unittest | `70.14% <ø> (+4.39%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.40% <0.00%> (-7.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `79.74% <0.00%> (-6.52%)` | :arrow_down: |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.55% <0.00%> (-1.35%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-0.96%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.39% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [390 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [7b4b0d1...0ff1451](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b4b0d1c610a3bd4a46f264b1a8e7d7f5656717d&el=desc) will **increase** coverage by `4.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.75% 70.10% +4.35%
==========================================
Files 569 182 -387
Lines 29501 17477 -12024
Branches 3040 0 -3040
==========================================
- Hits 19397 12253 -7144
+ Misses 9920 5224 -4696
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (-0.61%)` | :arrow_down: |
| #python | `70.10% <ø> (-0.69%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (-0.61%)` | :arrow_down: |
| #unittest | `70.10% <ø> (+4.35%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.40% <0.00%> (-7.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `79.74% <0.00%> (-6.52%)` | :arrow_down: |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.55% <0.00%> (-1.35%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-0.96%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.39% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [391 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [7b4b0d1...512928c](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409265932
##########
File path: superset-frontend/src/explore/controlPanels/Bubble.js
##########
@@ -39,15 +72,22 @@ export default {
expanded: true,
controlSetRows: [
['color_scheme', 'label_colors'],
- ['show_legend', null],
+ [showLegend, null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'left_margin'],
- ['x_axis_format', 'x_ticks_layout'],
+ [xAxisLabel, leftMargin],
+ [
+ {
+ ...xAxisFormat,
Review comment:
`xAxisFormat` is `{name, config}`.
Perhaps this should be changed to
```ts
{
name: xAxisFormat.name,
config: {
...xAxisFormat.config,
default: 'SMART_NUMBER',
choices: D3_FORMAT_OPTIONS,
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/314eb2fc54693cdb1de3874dc61224e8608b9838&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.43% 65.43%
=======================================
Files 574 574
Lines 29889 29889
Branches 3052 3052
=======================================
Hits 19557 19557
Misses 10148 10148
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #mysql | `70.08% <0.00%> (ø)` | |
| #postgres | `70.05% <0.00%> (ø)` | |
| #python | `70.17% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `65.43% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f40f012e3c4bb208f23912d2cd54d947a4feaeb1&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 70.14% 70.14%
=======================================
Files 182 182
Lines 17477 17477
=======================================
Hits 12260 12260
Misses 5217 5217
```
| Flag | Coverage Δ | |
|---|---|---|
| #mysql | `70.08% <0.00%> (ø)` | |
| #postgres | `70.05% <0.00%> (ø)` | |
| #python | `70.14% <0.00%> (ø)` | |
| #unittest | `70.14% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [f40f012...f40f012](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/30916adc5938cdf28689bf9a5c6c53380f69eac4&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.27% 65.27%
=======================================
Files 574 574
Lines 29887 29887
Branches 3049 3049
=======================================
Hits 19510 19510
Misses 10193 10193
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #python | `69.92% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `65.27% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [30916ad...30916ad](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **increase** coverage by `4.74%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.43% 70.17% +4.74%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19529 12265 -7264
+ Misses 10134 5212 -4922
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `70.08% <ø> (ø)` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.17% <ø> (+0.03%)` | :arrow_up: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `70.17% <ø> (+4.74%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | | |
| [...-frontend/src/datasource/ChangeDatasourceModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLmpzeA==) | | |
| [...essageToasts/utils/getToastsFromPyFlashMessages.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdXRpbHMvZ2V0VG9hc3RzRnJvbVB5Rmxhc2hNZXNzYWdlcy5qcw==) | | |
| [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | | |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | | |
| [superset-frontend/src/CRUD/CollectionTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLmpzeA==) | | |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | | |
| [superset-frontend/src/components/Button.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uLmpzeA==) | | |
| [...frontend/src/components/ListView/LegacyFilters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGVnYWN5RmlsdGVycy50c3g=) | | |
| [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | | |
| ... and [373 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [30916ad...30916ad](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f23310947be9b9a5bdafc60e955fed5937e13979&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.48% 65.48%
=======================================
Files 574 574
Lines 29937 29937
Branches 3054 3054
=======================================
Hits 19604 19604
Misses 10149 10149
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <0.00%> (ø)` | |
| #mysql | `70.15% <0.00%> (ø)` | |
| #postgres | `70.13% <0.00%> (ø)` | |
| #python | `70.25% <0.00%> (ø)` | |
| #sqlite | `69.99% <0.00%> (ø)` | |
| #unittest | `65.48% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [f233109...f233109](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409263969
##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -120,8 +121,9 @@ class FilterBox extends React.Component {
getControlData(controlName) {
const { selectedValues } = this.state;
+ const controlsMap = getControlsInventory(controlName);
Review comment:
Should this be `getControlsInventory(vizType)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f29d0fd9f2f93cf27e55475c61130518060d17fc&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 58.78% 58.75% -0.03%
==========================================
Files 390 392 +2
Lines 12386 12394 +8
Branches 3073 3073
==========================================
+ Hits 7281 7282 +1
- Misses 4921 4928 +7
Partials 184 184
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | `90.42% <0.00%> (+1.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [f29d0fd...0b7b5c0](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #9525: Migrating
shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b4b0d1c610a3bd4a46f264b1a8e7d7f5656717d&el=desc) will **increase** coverage by `4.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.75% 70.17% +4.42%
==========================================
Files 569 182 -387
Lines 29501 17477 -12024
Branches 3040 0 -3040
==========================================
- Hits 19397 12265 -7132
+ Misses 9920 5212 -4708
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `70.08% <ø> (-0.61%)` | :arrow_down: |
| #postgres | `70.05% <ø> (-0.61%)` | :arrow_down: |
| #python | `70.17% <ø> (-0.62%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (-0.61%)` | :arrow_down: |
| #unittest | `70.17% <ø> (+4.42%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.40% <0.00%> (-7.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `79.74% <0.00%> (-6.52%)` | :arrow_down: |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.55% <0.00%> (-1.35%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-0.96%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.39% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...c/visualizations/FilterBox/FilterBoxChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3hDaGFydFBsdWdpbi5qcw==) | | |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | | |
| ... and [388 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [7b4b0d1...512928c](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409669286
##########
File path: superset-frontend/src/utils/chartControlsInventory.js
##########
@@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import memoize from 'lodash/memoize';
+import { getChartControlPanelRegistry } from '@superset-ui/chart';
+import controls from '../explore/controls';
+
+const getControlsInventory = memoize(vizType => {
Review comment:
sure! I went with `getControlsForVizType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409299575
##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -120,8 +121,9 @@ class FilterBox extends React.Component {
getControlData(controlName) {
const { selectedValues } = this.state;
+ const controlsMap = getControlsInventory(controlName);
Review comment:
Actually, I backed this change out, to pull these controls (by key) from `controls.jsx` as it was before. This part apparently loads control configs for `druid_time_origin`, `granularity`, `granularity_sqla`, and `time_grain_sqla` which are part of `controls.jsx` and are NOT part of the controls included in `FilterBox.jsx`.
Soon, my plan (and we can talk about this if I'm not making sense here) is to make a `GlobalControls.jsx` file with the widely-shared controls, structured sort of like the `Shared_NVD3.js` and `Shared_DeckGL.jsx` files, so we can import/load objects by reference rather than a string. At that point, I'll revisit this chunk of code, thus the TODO I've added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409264473
##########
File path: superset-frontend/src/explore/controlPanels/Bar.js
##########
@@ -29,39 +49,33 @@ export default {
expanded: true,
controlSetRows: [
['color_scheme', 'label_colors'],
- ['show_brush', 'show_legend', 'show_bar_value'],
- ['rich_tooltip', 'bar_stacked'],
- ['line_interpolation', 'show_controls'],
- ['bottom_margin'],
+ [showBrush, showLegend, showBarValue],
+ [richTooltip, barStacked],
+ [lineInterpolation, showControls],
+ [bottomMargin],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_ticks_layout', 'x_axis_format'],
- ['x_axis_showminmax', 'reduce_x_ticks'],
+ [xAxisLabel, bottomMargin],
+ [xTicksLayout, xAxisFormat],
Review comment:
This one also did not apply override to `xAxisFormat`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9525: [WiP]
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f29d0fd9f2f93cf27e55475c61130518060d17fc&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 58.78% 58.77% -0.02%
==========================================
Files 390 392 +2
Lines 12386 12390 +4
Branches 3073 3073
==========================================
+ Hits 7281 7282 +1
- Misses 4921 4924 +3
Partials 184 184
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | `90.42% <0.00%> (+1.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [f29d0fd...bab4c04](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **increase** coverage by `4.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.43% 69.92% +4.49%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19529 12220 -7309
+ Misses 10134 5257 -4877
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #python | `69.92% <ø> (-0.23%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `69.92% <ø> (+4.49%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `86.06% <0.00%> (-0.16%)` | :arrow_down: |
| [...dashboard/components/menu/MarkdownModeDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvTWFya2Rvd25Nb2RlRHJvcGRvd24uanN4) | | |
| [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Nob3VsZFdyYXBDaGlsZEluUm93Lmpz) | | |
| ... and [380 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [30916ad...30916ad](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f32ee8de939222939e2b8811ea65eb0e33eae610&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 69.92% 69.92%
=======================================
Files 182 182
Lines 17477 17477
=======================================
Hits 12220 12220
Misses 5257 5257
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `69.92% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `69.92% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [f32ee8d...f32ee8d](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `52.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 65.43% 65.27% -0.16%
==========================================
Files 571 574 +3
Lines 29847 29890 +43
Branches 3040 3052 +12
==========================================
- Hits 19529 19512 -17
- Misses 10134 10194 +60
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <52.00%> (-0.03%)` | :arrow_down: |
| #mysql | `?` | |
| #python | `69.92% <ø> (-0.23%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `65.27% <52.00%> (-0.16%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | `27.77% <0.00%> (-1.64%)` | :arrow_down: |
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.04% <0.00%> (-0.05%)` | :arrow_down: |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.82% <100.00%> (+0.13%)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b4b0d1c610a3bd4a46f264b1a8e7d7f5656717d&el=desc) will **decrease** coverage by `6.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 65.75% 58.75% -7.00%
==========================================
Files 569 392 -177
Lines 29501 12394 -17107
Branches 3040 3073 +33
==========================================
- Hits 19397 7282 -12115
+ Misses 9920 4928 -4992
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `?` | |
| #python | `?` | |
| #sqlite | `?` | |
| #unittest | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [...rset-frontend/src/explore/controlPanels/DeckArc.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrQXJjLmpz) | `0.00% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckGeojson.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrR2VvanNvbi5qcw==) | `0.00% <0.00%> (ø)` | |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `13.23% <0.00%> (ø)` | |
| [...ontend/src/explore/controlPanels/Shared\_DeckGL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfRGVja0dMLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...nd/src/explore/components/controls/TextControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC5qc3g=) | `13.79% <0.00%> (ø)` | |
| ... and [186 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [7b4b0d1...f64704b](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r410030499
##########
File path: superset-frontend/src/explore/controlPanels/Compare.js
##########
@@ -19,6 +19,18 @@
import { t } from '@superset-ui/translation';
import { NVD3TimeSeries, annotations } from './sections';
import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import {
+ xAxisLabel,
+ yAxisLabel,
+ bottomMargin,
+ xTicksLayout,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ leftMargin,
+} from './Shared_NVD3';
Review comment:
Thanks for the clarification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b4b0d1c610a3bd4a46f264b1a8e7d7f5656717d&el=desc) will **increase** coverage by `4.30%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.75% 70.05% +4.30%
==========================================
Files 569 182 -387
Lines 29501 17477 -12024
Branches 3040 0 -3040
==========================================
- Hits 19397 12244 -7153
+ Misses 9920 5233 -4687
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (-0.61%)` | :arrow_down: |
| #python | `70.05% <ø> (-0.74%)` | :arrow_down: |
| #sqlite | `?` | |
| #unittest | `70.05% <ø> (+4.30%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.40% <0.00%> (-7.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `79.74% <0.00%> (-6.52%)` | :arrow_down: |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.55% <0.00%> (-1.35%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.17%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-0.96%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| ... and [394 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [7b4b0d1...0ff1451](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409992072
##########
File path: superset-frontend/spec/javascripts/utils/chartControlsInventory_spec.js
##########
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { getChartControlPanelRegistry } from '@superset-ui/chart';
+import getControlsForVizType from 'src/utils/chartControlsInventory';
+
+const fakePluginControls = {
+ controlPanelSections: [
+ {
+ label: 'Fake Control Panel Sections',
+ expanded: true,
+ controlSetRows: [
+ ['url_params'],
+ [
+ {
+ name: 'y_axis_bounds',
+ config: {
+ type: 'BoundsControl',
+ label: 'Value bounds',
+ default: [null, null],
+ description: 'Value bounds for the y axis',
+ },
+ },
+ ],
+ [
+ {
+ name: 'adhoc_filters',
+ config: {
+ type: 'AdhocFilterControl',
+ label: 'Fake Filters',
+ default: null,
+ },
+ },
+ ],
+ ],
+ },
+ {
+ label: 'Fake Control Panel Sections 2',
+ expanded: true,
+ controlSetRows: [
+ [
+ {
+ name: 'column_collection',
+ config: {
+ type: 'CollectionControl',
+ label: 'Fake Collection Control',
+ },
+ },
+ ],
+ ],
+ },
+ ],
+};
+
+describe('chartControlsInventory', () => {
Review comment:
Done ✅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409893726
##########
File path: superset-frontend/spec/javascripts/utils/chartControlsInventory_spec.js
##########
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { getChartControlPanelRegistry } from '@superset-ui/chart';
+import getControlsForVizType from 'src/utils/chartControlsInventory';
+
+const fakePluginControls = {
+ controlPanelSections: [
+ {
+ label: 'Fake Control Panel Sections',
+ expanded: true,
+ controlSetRows: [
+ ['url_params'],
+ [
+ {
+ name: 'y_axis_bounds',
+ config: {
+ type: 'BoundsControl',
+ label: 'Value bounds',
+ default: [null, null],
+ description: 'Value bounds for the y axis',
+ },
+ },
+ ],
+ [
+ {
+ name: 'adhoc_filters',
+ config: {
+ type: 'AdhocFilterControl',
+ label: 'Fake Filters',
+ default: null,
+ },
+ },
+ ],
+ ],
+ },
+ {
+ label: 'Fake Control Panel Sections 2',
+ expanded: true,
+ controlSetRows: [
+ [
+ {
+ name: 'column_collection',
+ config: {
+ type: 'CollectionControl',
+ label: 'Fake Collection Control',
+ },
+ },
+ ],
+ ],
+ },
+ ],
+};
+
+describe('chartControlsInventory', () => {
Review comment:
rename
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **increase** coverage by `4.74%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.43% 70.17% +4.74%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19529 12265 -7264
+ Misses 10134 5212 -4922
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `70.08% <ø> (ø)` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.17% <ø> (+0.03%)` | :arrow_up: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `70.17% <ø> (+4.74%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | | |
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | | |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | | |
| [superset-frontend/src/components/Menu/UserMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9Vc2VyTWVudS5qc3g=) | | |
| [superset-frontend/src/showSavedQuery/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L3V0aWxzLmpz) | | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | | |
| [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | | |
| [...-frontend/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrU2NhdHRlci5qcw==) | | |
| [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | | |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | | |
| ... and [374 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [08e10b4...08e10b4](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/314eb2fc54693cdb1de3874dc61224e8608b9838&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.39% 65.39%
=======================================
Files 574 574
Lines 29889 29889
Branches 3052 3052
=======================================
Hits 19545 19545
Misses 10160 10160
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #postgres | `70.05% <0.00%> (ø)` | |
| #python | `70.10% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `65.39% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a8021ed07959981f41cae57938f769f85f4dfd32&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.63% 65.63%
=======================================
Files 574 574
Lines 30060 30060
Branches 3054 3054
=======================================
Hits 19729 19729
Misses 10147 10147
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <0.00%> (ø)` | |
| #python | `70.46% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [a8021ed...a8021ed](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b4b0d1c610a3bd4a46f264b1a8e7d7f5656717d&el=desc) will **increase** coverage by `4.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.75% 69.92% +4.17%
==========================================
Files 569 182 -387
Lines 29501 17477 -12024
Branches 3040 0 -3040
==========================================
- Hits 19397 12220 -7177
+ Misses 9920 5257 -4663
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `?` | |
| #python | `69.92% <ø> (-0.87%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (-0.61%)` | :arrow_down: |
| #unittest | `69.92% <ø> (+4.17%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.40% <0.00%> (-7.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `79.74% <0.00%> (-6.52%)` | :arrow_down: |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.55% <0.00%> (-1.35%)` | :arrow_down: |
| ... and [397 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [7b4b0d1...7636541](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `52.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 65.43% 65.38% -0.05%
==========================================
Files 571 574 +3
Lines 29847 29890 +43
Branches 3040 3052 +12
==========================================
+ Hits 19529 19545 +16
- Misses 10134 10161 +27
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <52.00%> (-0.03%)` | :arrow_down: |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.10% <ø> (-0.04%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `65.38% <52.00%> (-0.05%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | `27.77% <0.00%> (-1.64%)` | :arrow_down: |
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.04% <0.00%> (-0.05%)` | :arrow_down: |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.82% <100.00%> (+0.13%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/314eb2fc54693cdb1de3874dc61224e8608b9838&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.39% 65.39%
=======================================
Files 574 574
Lines 29889 29889
Branches 3052 3052
=======================================
Hits 19545 19545
Misses 10160 10160
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <0.00%> (ø)` | |
| #postgres | `70.05% <0.00%> (ø)` | |
| #python | `70.10% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `65.39% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409991982
##########
File path: superset-frontend/src/explore/controlPanels/TimePivot.js
##########
@@ -17,47 +17,99 @@
* under the License.
*/
import { t } from '@superset-ui/translation';
-import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import { D3_FORMAT_OPTIONS } from '../controls';
+import {
+ lineInterpolation,
+ showLegend,
+ xAxisLabel,
+ bottomMargin,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ yAxisLabel,
+ leftMargin,
+} from './Shared_NVD3';
export default {
requiresTime: true,
controlPanelSections: [
{
label: t('Query'),
expanded: true,
- controlSetRows: [['metric'], ['adhoc_filters'], ['freq']],
+ controlSetRows: [
+ ['metric'],
+ ['adhoc_filters'],
+ [
+ {
+ name: 'freq',
+ config: {
+ type: 'SelectControl',
+ label: t('Frequency'),
+ default: 'W-MON',
+ freeForm: true,
+ clearable: false,
+ choices: [
+ ['AS', 'Year (freq=AS)'],
+ ['52W-MON', '52 weeks starting Monday (freq=52W-MON)'],
+ ['W-SUN', '1 week starting Sunday (freq=W-SUN)'],
+ ['W-MON', '1 week starting Monday (freq=W-MON)'],
+ ['D', 'Day (freq=D)'],
+ ['4W-MON', '4 weeks (freq=4W-MON)'],
+ ],
+ description: t(
+ `The periodicity over which to pivot time. Users can provide
+ "Pandas" offset alias.
+ Click on the info bubble for more details on accepted "freq" expressions.`,
+ ),
+ tooltipOnClick: () => {
+ window.open(
+ 'https://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases',
+ );
+ },
+ },
+ },
+ ],
+ ],
},
{
label: t('Chart Options'),
expanded: true,
controlSetRows: [
- ['show_legend', 'line_interpolation'],
+ [showLegend, lineInterpolation],
['color_picker', null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_axis_showminmax', 'x_axis_format'],
+ [xAxisLabel, bottomMargin],
+ [
+ xAxisShowMinmax,
+ {
Review comment:
Honestly, I just made the mistake because I was having a copy-paste party late at night. I don't think I would have made a mistake if I were actually trying to override a control with a specific intent.
My concern is that a function like this adds another onion layer for devs to figure out. Figuring out that you need to pass in a complete config and a partial config to this function (and why) seems like it might be just as error-prone.
I think the spread syntax is straightforward enough for people to figure out quite quickly. We could always re-enable `Object.assign` if that's any more transparent in intent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **increase** coverage by `4.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.43% 70.10% +4.67%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19529 12253 -7276
+ Misses 10134 5224 -4910
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.10% <ø> (-0.04%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `70.10% <ø> (+4.67%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [...dashboard/components/menu/MarkdownModeDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvTWFya2Rvd25Nb2RlRHJvcGRvd24uanN4) | | |
| [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Nob3VsZFdyYXBDaGlsZEluUm93Lmpz) | | |
| [superset-frontend/src/components/Menu/NewMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LmpzeA==) | | |
| [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | | |
| [superset-frontend/src/components/FormRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybVJvdy5qc3g=) | | |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | | |
| [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | | |
| ... and [376 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [30916ad...30916ad](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **increase** coverage by `4.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.43% 70.10% +4.67%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19529 12253 -7276
+ Misses 10134 5224 -4910
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.10% <ø> (-0.04%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `70.10% <ø> (+4.67%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [superset-frontend/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3NhZmVTdHJpbmdpZnkudHM=) | | |
| [...-frontend/src/explore/reducers/saveModalReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvc2F2ZU1vZGFsUmVkdWNlci5qcw==) | | |
| [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | | |
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
| [...nd/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENvbXBvbmVudFdpZHRoRnJvbURyb3AuanM=) | | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | | |
| [superset-frontend/src/utils/hostNamesConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2hvc3ROYW1lc0NvbmZpZy5qcw==) | | |
| ... and [377 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [08e10b4...08e10b4](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409989607
##########
File path: superset-frontend/src/utils/chartControlsInventory.js
##########
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import memoize from 'lodash/memoize';
+import { getChartControlPanelRegistry } from '@superset-ui/chart';
+import controls from '../explore/controls';
+
+const getControlsForVizType = memoize(vizType => {
Review comment:
renamed... we might be able to get rid of this file in time, but I have a hunch we'll need it again, so I'd like to leave it for the time being :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409887996
##########
File path: superset-frontend/src/utils/chartControlsInventory.js
##########
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import memoize from 'lodash/memoize';
+import { getChartControlPanelRegistry } from '@superset-ui/chart';
+import controls from '../explore/controls';
+
+const getControlsForVizType = memoize(vizType => {
Review comment:
Please rename the file to match this function name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b4b0d1c610a3bd4a46f264b1a8e7d7f5656717d&el=desc) will **increase** coverage by `4.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.75% 70.14% +4.39%
==========================================
Files 569 182 -387
Lines 29501 17477 -12024
Branches 3040 0 -3040
==========================================
- Hits 19397 12260 -7137
+ Misses 9920 5217 -4703
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `70.08% <ø> (-0.61%)` | :arrow_down: |
| #postgres | `70.05% <ø> (-0.61%)` | :arrow_down: |
| #python | `70.14% <ø> (-0.65%)` | :arrow_down: |
| #sqlite | `?` | |
| #unittest | `70.14% <ø> (+4.39%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.40% <0.00%> (-7.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `79.74% <0.00%> (-6.52%)` | :arrow_down: |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.55% <0.00%> (-1.35%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-0.96%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.39% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [390 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [7b4b0d1...0ff1451](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409893245
##########
File path: superset-frontend/src/explore/controlPanels/TimePivot.js
##########
@@ -17,47 +17,99 @@
* under the License.
*/
import { t } from '@superset-ui/translation';
-import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import { D3_FORMAT_OPTIONS } from '../controls';
+import {
+ lineInterpolation,
+ showLegend,
+ xAxisLabel,
+ bottomMargin,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ yAxisLabel,
+ leftMargin,
+} from './Shared_NVD3';
export default {
requiresTime: true,
controlPanelSections: [
{
label: t('Query'),
expanded: true,
- controlSetRows: [['metric'], ['adhoc_filters'], ['freq']],
+ controlSetRows: [
+ ['metric'],
+ ['adhoc_filters'],
+ [
+ {
+ name: 'freq',
+ config: {
+ type: 'SelectControl',
+ label: t('Frequency'),
+ default: 'W-MON',
+ freeForm: true,
+ clearable: false,
+ choices: [
+ ['AS', 'Year (freq=AS)'],
+ ['52W-MON', '52 weeks starting Monday (freq=52W-MON)'],
+ ['W-SUN', '1 week starting Sunday (freq=W-SUN)'],
+ ['W-MON', '1 week starting Monday (freq=W-MON)'],
+ ['D', 'Day (freq=D)'],
+ ['4W-MON', '4 weeks (freq=4W-MON)'],
+ ],
+ description: t(
+ `The periodicity over which to pivot time. Users can provide
+ "Pandas" offset alias.
+ Click on the info bubble for more details on accepted "freq" expressions.`,
+ ),
+ tooltipOnClick: () => {
+ window.open(
+ 'https://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases',
+ );
+ },
+ },
+ },
+ ],
+ ],
},
{
label: t('Chart Options'),
expanded: true,
controlSetRows: [
- ['show_legend', 'line_interpolation'],
+ [showLegend, lineInterpolation],
['color_picker', null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_axis_showminmax', 'x_axis_format'],
+ [xAxisLabel, bottomMargin],
+ [
+ xAxisShowMinmax,
+ {
Review comment:
Let's create a util function for convenience and to avoid mistake in the future.
Can also leverage typescript.
```ts
// Can add stronger typing per control type later
interface ControlConfig {
type: string;
label: string;
description?: string;
renderTrigger: boolean;
[key: string]: unknown;
}
interface FieldConfig {
name: string;
config: ControlConfig;
}
export default function overrideFieldConfig(
base: FieldConfig,
override: Partial<ControlConfig>,
): FieldConfig {
const { name, config } = base;
return {
name,
config: { ...config, override },
};
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **increase** coverage by `4.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.43% 70.10% +4.67%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19529 12253 -7276
+ Misses 10134 5224 -4910
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.10% <ø> (-0.04%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `70.10% <ø> (+4.67%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | | |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | |
| [...nd/src/messageToasts/containers/ToastPresenter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29udGFpbmVycy9Ub2FzdFByZXNlbnRlci5qc3g=) | | |
| [...nd/src/messageToasts/components/ToastPresenter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdFByZXNlbnRlci5qc3g=) | | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | | |
| ... and [377 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [08e10b4...08e10b4](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f23310947be9b9a5bdafc60e955fed5937e13979&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 58.75% 58.75%
=======================================
Files 392 392
Lines 12414 12414
Branches 3054 3054
=======================================
Hits 7294 7294
Misses 4936 4936
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <0.00%> (ø)` | |
| #unittest | `58.75% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [f233109...f233109](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `52.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 65.43% 65.42% -0.01%
==========================================
Files 571 574 +3
Lines 29847 29890 +43
Branches 3040 3052 +12
==========================================
+ Hits 19529 19557 +28
- Misses 10134 10149 +15
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <52.00%> (-0.03%)` | :arrow_down: |
| #mysql | `70.08% <ø> (ø)` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.17% <ø> (+0.03%)` | :arrow_up: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `65.42% <52.00%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | `27.77% <0.00%> (-1.64%)` | :arrow_down: |
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.04% <0.00%> (-0.05%)` | :arrow_down: |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.82% <100.00%> (+0.13%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [314eb2f...314eb2f](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409265198
##########
File path: superset-frontend/src/utils/chartControlsInventory.js
##########
@@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import memoize from 'lodash/memoize';
+import { getChartControlPanelRegistry } from '@superset-ui/chart';
+import controls from '../explore/controls';
+
+const getControlsInventory = memoize(vizType => {
Review comment:
function name does not match file name.
How about `getControlsForChartType()` or `getControlsForVizType()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409268337
##########
File path: superset-frontend/src/explore/controlPanels/Bar.js
##########
@@ -29,39 +49,33 @@ export default {
expanded: true,
controlSetRows: [
['color_scheme', 'label_colors'],
- ['show_brush', 'show_legend', 'show_bar_value'],
- ['rich_tooltip', 'bar_stacked'],
- ['line_interpolation', 'show_controls'],
- ['bottom_margin'],
+ [showBrush, showLegend, showBarValue],
+ [richTooltip, barStacked],
+ [lineInterpolation, showControls],
+ [bottomMargin],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_ticks_layout', 'x_axis_format'],
- ['x_axis_showminmax', 'reduce_x_ticks'],
+ [xAxisLabel, bottomMargin],
+ [xTicksLayout, xAxisFormat],
Review comment:
Same as above... I swapped the defaults/overrides, since there were more _with_ identical overrides than without.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/30916adc5938cdf28689bf9a5c6c53380f69eac4&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 69.92% 69.92%
=======================================
Files 182 182
Lines 17477 17477
=======================================
Hits 12220 12220
Misses 5257 5257
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `69.92% <0.00%> (ø)` | |
| #sqlite | `69.92% <0.00%> (ø)` | |
| #unittest | `69.92% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [30916ad...30916ad](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9525: Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#discussion_r409991982
##########
File path: superset-frontend/src/explore/controlPanels/TimePivot.js
##########
@@ -17,47 +17,99 @@
* under the License.
*/
import { t } from '@superset-ui/translation';
-import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import { D3_FORMAT_OPTIONS } from '../controls';
+import {
+ lineInterpolation,
+ showLegend,
+ xAxisLabel,
+ bottomMargin,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ yAxisLabel,
+ leftMargin,
+} from './Shared_NVD3';
export default {
requiresTime: true,
controlPanelSections: [
{
label: t('Query'),
expanded: true,
- controlSetRows: [['metric'], ['adhoc_filters'], ['freq']],
+ controlSetRows: [
+ ['metric'],
+ ['adhoc_filters'],
+ [
+ {
+ name: 'freq',
+ config: {
+ type: 'SelectControl',
+ label: t('Frequency'),
+ default: 'W-MON',
+ freeForm: true,
+ clearable: false,
+ choices: [
+ ['AS', 'Year (freq=AS)'],
+ ['52W-MON', '52 weeks starting Monday (freq=52W-MON)'],
+ ['W-SUN', '1 week starting Sunday (freq=W-SUN)'],
+ ['W-MON', '1 week starting Monday (freq=W-MON)'],
+ ['D', 'Day (freq=D)'],
+ ['4W-MON', '4 weeks (freq=4W-MON)'],
+ ],
+ description: t(
+ `The periodicity over which to pivot time. Users can provide
+ "Pandas" offset alias.
+ Click on the info bubble for more details on accepted "freq" expressions.`,
+ ),
+ tooltipOnClick: () => {
+ window.open(
+ 'https://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases',
+ );
+ },
+ },
+ },
+ ],
+ ],
},
{
label: t('Chart Options'),
expanded: true,
controlSetRows: [
- ['show_legend', 'line_interpolation'],
+ [showLegend, lineInterpolation],
['color_picker', null],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_axis_showminmax', 'x_axis_format'],
+ [xAxisLabel, bottomMargin],
+ [
+ xAxisShowMinmax,
+ {
Review comment:
Honestly, I just made the mistake because I was having a copy-paste party late at night. I don't think I would have made a mistake if I were actually trying to override a control with a specific intent.
My concern is that a function like this adds another onion layer for devs to figure out... in the end, having to figure out that you pass in a complete config and a partial config to make it work seems just as error-prone.
I think the spread syntax is straightforward enough... or we could re-enable people to use Object.assign if that's any more straightforward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a8021ed07959981f41cae57938f769f85f4dfd32&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.47% 65.47%
=======================================
Files 574 574
Lines 30060 30060
Branches 3054 3054
=======================================
Hits 19681 19681
Misses 10195 10195
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <0.00%> (ø)` | |
| #python | `70.19% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [a8021ed...a8021ed](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b4b0d1c610a3bd4a46f264b1a8e7d7f5656717d&el=desc) will **increase** coverage by `4.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
+ Coverage 65.75% 70.10% +4.35%
==========================================
Files 569 182 -387
Lines 29501 17477 -12024
Branches 3040 0 -3040
==========================================
- Hits 19397 12253 -7144
+ Misses 9920 5224 -4696
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (-0.61%)` | :arrow_down: |
| #python | `70.10% <ø> (-0.69%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (-0.61%)` | :arrow_down: |
| #unittest | `70.10% <ø> (+4.35%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.40% <0.00%> (-7.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `79.74% <0.00%> (-6.52%)` | :arrow_down: |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.55% <0.00%> (-1.35%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-0.96%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.39% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [391 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [7b4b0d1...512928c](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f23310947be9b9a5bdafc60e955fed5937e13979&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
Coverage 65.33% 65.33%
=======================================
Files 574 574
Lines 29937 29937
Branches 3054 3054
=======================================
Hits 19559 19559
Misses 10194 10194
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <0.00%> (ø)` | |
| #python | `69.99% <0.00%> (ø)` | |
| #sqlite | `69.99% <0.00%> (ø)` | |
| #unittest | `65.33% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [f233109...f233109](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4a55e1ea3a055e6fe27a8132415711c7f61b80f7&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `53.06%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 65.50% 65.48% -0.02%
==========================================
Files 571 574 +3
Lines 29895 29937 +42
Branches 3042 3054 +12
==========================================
+ Hits 19582 19604 +22
- Misses 10129 10149 +20
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <53.06%> (-0.03%)` | :arrow_down: |
| #mysql | `70.15% <ø> (ø)` | |
| #postgres | `70.13% <ø> (ø)` | |
| #python | `70.25% <ø> (ø)` | |
| #sqlite | `69.99% <ø> (ø)` | |
| #unittest | `65.48% <53.06%> (-0.02%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | `27.77% <0.00%> (-1.64%)` | :arrow_down: |
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.08% <ø> (ø)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.82% <100.00%> (+0.13%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [a8021ed...a8021ed](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9525:
[WiP] Migrating shared NVD3 controls to new module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 controls to new module
URL: https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1) Report
> Merging [#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `51.06%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9525 +/- ##
==========================================
- Coverage 65.43% 65.38% -0.05%
==========================================
Files 571 574 +3
Lines 29847 29887 +40
Branches 3040 3049 +9
==========================================
+ Hits 19529 19543 +14
- Misses 10134 10160 +26
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.74% <51.06%> (-0.03%)` | :arrow_down: |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (?)` | |
| #python | `70.10% <ø> (-0.04%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `65.38% <51.06%> (-0.05%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `43.68% <ø> (+0.83%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.04% <0.00%> (-0.05%)` | :arrow_down: |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.82% <100.00%> (+0.13%)` | :arrow_up: |
| [...erset-frontend/src/utils/chartControlsInventory.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NoYXJ0Q29udHJvbHNJbnZlbnRvcnkuanM=) | `100.00% <100.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer). Last update [29bbc62...29bbc62](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org