You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Prakash Udupa (JIRA)" <de...@myfaces.apache.org> on 2011/05/27 00:32:47 UTC
[jira] [Created] (TRINIDAD-2106) RowkeySetAttributeChange should
handle gracefully when the RowKeySet object it is remembering could be in
invalid state
RowkeySetAttributeChange should handle gracefully when the RowKeySet object it is remembering could be in invalid state
-----------------------------------------------------------------------------------------------------------------------
Key: TRINIDAD-2106
URL: https://issues.apache.org/jira/browse/TRINIDAD-2106
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 1.2.12-core
Reporter: Prakash Udupa
The implementation of RowKeySetAttributeChange assumes that RowKeySet values of attributes can be saved off and restored at a later point in time. Reality is that some implementations of RowKeySet can be strongly bound to their model layer that basic collection operations like iterator() / addAll() would fail with any kind of exceptions, because between the time it was saved to the time it is tried to be restored, the underlying model has become stale.
The fix for the issue is for RowKeySetAttributeChange to defensively check if the remembered RowKeySet is in a valid state (iterable / operable) before attempting to restore the customization. A similar bug was encountered and solved in trunk and 2.0.0.1 branch as part of solving TRINIDAD-2073. So this issue does not exist in those branches. I'd submit a patch over 1.2.12.5.1 branch soon.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2106) RowkeySetAttributeChange should
handle gracefully when the RowKeySet object it is remembering could be in
invalid state
Posted by "Prakash Udupa (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Udupa updated TRINIDAD-2106:
------------------------------------
Status: Patch Available (was: Open)
> RowkeySetAttributeChange should handle gracefully when the RowKeySet object it is remembering could be in invalid state
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2106
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2106
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Reporter: Prakash Udupa
> Attachments: TRINIDAD-2106_patch_over_1_2_12_5_1.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The implementation of RowKeySetAttributeChange assumes that RowKeySet values of attributes can be saved off and restored at a later point in time. Reality is that some implementations of RowKeySet can be strongly bound to their model layer that basic collection operations like iterator() / addAll() would fail with any kind of exceptions, because between the time it was saved to the time it is tried to be restored, the underlying model has become stale.
> The fix for the issue is for RowKeySetAttributeChange to defensively check if the remembered RowKeySet is in a valid state (iterable / operable) before attempting to restore the customization. A similar bug was encountered and solved in trunk and 2.0.0.1 branch as part of solving TRINIDAD-2073. So this issue does not exist in those branches. I'd submit a patch over 1.2.12.5.1 branch soon.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2106) RowkeySetAttributeChange should
handle gracefully when the RowKeySet object it is remembering could be in
invalid state
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan updated TRINIDAD-2106:
------------------------------------
Resolution: Fixed
Assignee: Scott O'Bryan
Status: Resolved (was: Patch Available)
> RowkeySetAttributeChange should handle gracefully when the RowKeySet object it is remembering could be in invalid state
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2106
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2106
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Reporter: Prakash Udupa
> Assignee: Scott O'Bryan
> Attachments: TRINIDAD-2106_patch_over_1_2_12_5_1.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The implementation of RowKeySetAttributeChange assumes that RowKeySet values of attributes can be saved off and restored at a later point in time. Reality is that some implementations of RowKeySet can be strongly bound to their model layer that basic collection operations like iterator() / addAll() would fail with any kind of exceptions, because between the time it was saved to the time it is tried to be restored, the underlying model has become stale.
> The fix for the issue is for RowKeySetAttributeChange to defensively check if the remembered RowKeySet is in a valid state (iterable / operable) before attempting to restore the customization. A similar bug was encountered and solved in trunk and 2.0.0.1 branch as part of solving TRINIDAD-2073. So this issue does not exist in those branches. I'd submit a patch over 1.2.12.5.1 branch soon.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira