You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "rahil-c (via GitHub)" <gi...@apache.org> on 2025/05/09 05:02:27 UTC
[PR] Add latest metadata path field [incubator-xtable]
rahil-c opened a new pull request, #710:
URL: https://github.com/apache/incubator-xtable/pull/710
## *Important Read*
- *Please ensure the GitHub issue is mentioned at the beginning of the PR*
## What is the purpose of the pull request
*(For example: This pull request implements the sync for delta format.)*
## Brief change log
*(for example:)*
- *Fixed JSON parsing error when persisting state*
- *Added unit tests for schema evolution*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added TestConversionController to verify the change.*
- *Manually verified the change by running a job locally.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add latest metadata path field [incubator-xtable]
Posted by "rahil-c (via GitHub)" <gi...@apache.org>.
rahil-c commented on PR #710:
URL: https://github.com/apache/incubator-xtable/pull/710#issuecomment-2865130384
@vinishjail97 is there a way to retrigger the ci, since the below test is passing but in ci it says failure.
<img width="2391" alt="Screenshot 2025-05-08 at 10 06 32 PM" src="https://github.com/user-attachments/assets/7bea37a7-9838-4cae-bf45-7d424256d2b4" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add latest metadata path field in InternalTable [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 merged PR #710:
URL: https://github.com/apache/incubator-xtable/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add latest metadata path field [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on code in PR #710:
URL: https://github.com/apache/incubator-xtable/pull/710#discussion_r2080989075
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java:
##########
@@ -128,6 +131,7 @@ public InternalTable getTable(Snapshot snapshot) {
.latestCommitTime(Instant.ofEpochMilli(snapshot.timestampMillis()))
.readSchema(irSchema)
.layoutStrategy(dataLayoutStrategy)
+ .latestMetdataPath(iceOps.current().metadataFileLocation())
Review Comment:
Can you assert in unit tests as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add latest metadata path field [incubator-xtable]
Posted by "rahil-c (via GitHub)" <gi...@apache.org>.
rahil-c commented on code in PR #710:
URL: https://github.com/apache/incubator-xtable/pull/710#discussion_r2082245083
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java:
##########
@@ -128,6 +131,7 @@ public InternalTable getTable(Snapshot snapshot) {
.latestCommitTime(Instant.ofEpochMilli(snapshot.timestampMillis()))
.readSchema(irSchema)
.layoutStrategy(dataLayoutStrategy)
+ .latestMetdataPath(iceOps.current().metadataFileLocation())
Review Comment:
have amended pr for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org