[jira] [Commented] (YARN-170) NodeManager stop() gets called twice on shutdown

["Sandy Ryza (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535143#comment-13535143 ] 

Sandy Ryza commented on YARN-170:
---------------------------------

Oops you're right about the race still being there.  I'll make stop() re-entrant and modify the test. 
                
> NodeManager stop() gets called twice on shutdown
> ------------------------------------------------
>
>                 Key: YARN-170
>                 URL: https://issues.apache.org/jira/browse/YARN-170
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-170-1.patch, YARN-170-2.patch, YARN-170.patch
>
>
> The stop method in the NodeManager gets called twice when the NodeManager is shut down via the shutdown hook.
> The first is the stop that gets called directly by the shutdown hook.  The second occurs when the NodeStatusUpdaterImpl is stopped.  The NodeManager responds to the NodeStatusUpdaterImpl stop stateChanged event by stopping itself.  This is so that NodeStatusUpdaterImpl can notify the NodeManager to stop, by stopping itself in response to a request from the ResourceManager
> This could be avoided if the NodeStatusUpdaterImpl were to stop the NodeManager by calling its stop method directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira