You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/07 17:35:18 UTC
[jira] [Commented] (BEAM-2423) Abstract StateInternalsTest for the
different state internals/Runners
[ https://issues.apache.org/jira/browse/BEAM-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041272#comment-16041272 ]
ASF GitHub Bot commented on BEAM-2423:
--------------------------------------
GitHub user JingsongLi opened a pull request:
https://github.com/apache/beam/pull/3313
[BEAM-2423] Abstract StateInternalsTest for the different state internals
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JingsongLi/beam BEAM-2423
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3313
----
commit f6448347163648c512779ba8be1ddc1a23be10dc
Author: JingsongLi <lz...@aliyun.com>
Date: 2017-06-07T17:31:34Z
[BEAM-2423] Abstract StateInternalsTest for the different state internals
----
> Abstract StateInternalsTest for the different state internals/Runners
> ---------------------------------------------------------------------
>
> Key: BEAM-2423
> URL: https://issues.apache.org/jira/browse/BEAM-2423
> Project: Beam
> Issue Type: Improvement
> Components: runner-core, runner-flink
> Reporter: Jingsong Lee
> Assignee: Jingsong Lee
>
> For the test of InMemoryStateInternals, ApexStateInternals, FlinkStateInternals, SparkStateInternals, etc..
> Have a common base class for the state internals test that has an abstract method createStateInternals() and all the test methods. Then an actual implementation would just derive from that and only implement the method for creating the state internals.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)