[GitHub] [daffodil-vscode] Shanedell commented on pull request #580: Provides the ability to re-select values of attributes items

["Shanedell (via GitHub)" <gi...@apache.org>]

Shanedell commented on PR #580:
URL: https://github.com/apache/daffodil-vscode/pull/580#issuecomment-1503755518

   @rt320 Can you please add some whitespace to the code. A lot of the code is to tightly together so adding some whitespaces would be helpful for reading. A lot of time before any `if`, `while`, `for` there should be a empty line before it unless nested for example
   
   ```ts
   for () {
     if () {
     
     }
   }
   ```
   
   is fine but
   
   ```ts
   for () {
     if () {
   
     }
     if() {
   
     }
   }
   ```
   
   should be 
   
   ```ts
   for () {
     if () {
   
     }
   
     if() {
   
     }
   }
   ```
   
   When you also change what is being done there should be an empty line. So if you go from making a bunch of variables to a `while` loop there should be a break in between
   
   eg:
   
   this:
   
   ```ts
   const var1 = 0
   const var2 = 0
   const var3 = 0
   const var4 = 0
   const var5 = 0
   while() {
   
   }
   ````
   
   should be
   
   ```ts
   const var1 = 0
   const var2 = 0
   const var3 = 0
   const var4 = 0
   const var5 = 0
   
   while() {
   
   }
   ````
   
   These are just minor formatting things that I think make the code easier to read


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org