[GitHub] [spark] mridulm commented on pull request #30131: [SPARK-33220][CORE]Use `scheduleWithFixedDelay` to avoid repeated unnecessary scheduling for a short time

[GitBox <gi...@apache.org>]

mridulm commented on pull request #30131:
URL: https://github.com/apache/spark/pull/30131#issuecomment-715882017


   Are you seeing issues with use of `scheduleAtFixedRate` which are fixed by `scheduleWithFixedDelay` ?
   There are nuances in the difference, which can have subtle impact. In the example you mentioned, if there is heavy gc after sending rpc request, but before task completes - fixed delay will be gc time + wait time vs just wait time.
   While the scenario mentioned in description is equally valid - two events getting fired very close to each other.
   
   If we are not observing issues currently, I would err on side of caution and not change behavior.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org