[GitHub] agrawaldevesh commented on a change in pull request #6719: Adding support for Pinot

[GitBox <gi...@apache.org>]

agrawaldevesh commented on a change in pull request #6719: Adding support for Pinot
URL: https://github.com/apache/incubator-superset/pull/6719#discussion_r251180612
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -126,13 +130,25 @@ def datasource(self):
 
     def get_time_filter(self, start_dttm, end_dttm):
         col = self.get_sqla_col(label='__time')
+        start_dttm_text = None
+        end_dttm_text = None
+        if start_dttm:
+            start_dttm_text = text(self.dttm_sql_literal(start_dttm))
+        if end_dttm:
+            end_dttm_text = text(self.dttm_sql_literal(end_dttm))
+        if self.db_spec.prefer_between_for_range_filters and start_dttm and end_dttm:
+            return col.between(start_dttm_text, end_dttm_text)
 
 Review comment:
   I will remove this. They fixed this bug in the pinot server that it no longer requires a between :-).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org