You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/10 04:24:00 UTC

[GitHub] [yunikorn-k8shim] wilfred-s commented on a diff in pull request #466: [YUNIKORN-1196] Build against Kubernetes 1.23.12

wilfred-s commented on code in PR #466:
URL: https://github.com/apache/yunikorn-k8shim/pull/466#discussion_r1018633647


##########
deployments/image/plugin/start-yunikorn-plugin.sh:
##########
@@ -17,13 +17,15 @@
 # limitations under the License.
 
 cd "${HOME}" || exit
+
+# Embed scheduler name into config file
+sed 's/schedulerName:.*/schedulerName: '"${SCHEDULER_NAME}"'/' < "${SCHEDULER_CONFIG}" > /tmp/scheduler-config.yaml || exit

Review Comment:
   We need to move this out of this shell script and into pre-processing as this requires `sed` to be installed in the image which might not be the case for stripped down setups.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org