You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/08/27 06:30:26 UTC

[GitHub] [zeppelin] Reamer opened a new pull request #4209: [ZEPPELIN-5497] Use AutoCloseable interface to close all IO

Reamer opened a new pull request #4209:
URL: https://github.com/apache/zeppelin/pull/4209


   ### What is this PR for?
   
   Should close clientPool explicitly, otherwise it won't be garbage collected.
   Take over of #4208 
   
   ### What type of PR is it?
    - Bug Fix
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5497
   
   ### How should this be tested?
   * via CI
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4209: [ZEPPELIN-5497] Use AutoCloseable interface to close all IO

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4209:
URL: https://github.com/apache/zeppelin/pull/4209


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4209: [ZEPPELIN-5497] Use AutoCloseable interface to close all IO

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4209:
URL: https://github.com/apache/zeppelin/pull/4209#issuecomment-908211815


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4209: [ZEPPELIN-5497] Use AutoCloseable interface to close all IO

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4209:
URL: https://github.com/apache/zeppelin/pull/4209#issuecomment-908209860


   I will merge this into the master on Wednesday if no other comments are received.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4209: [ZEPPELIN-5497] Use AutoCloseable interface to close all IO

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4209:
URL: https://github.com/apache/zeppelin/pull/4209#issuecomment-907171171


   @zjffdu Ready for review :grin: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org