You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Matthias Lehmann (JIRA)" <ji...@apache.org> on 2009/07/30 10:31:14 UTC

[jira] Created: (HBASE-1723) getRowWithColumnsTs changed behavior

getRowWithColumnsTs changed behavior
------------------------------------

                 Key: HBASE-1723
                 URL: https://issues.apache.org/jira/browse/HBASE-1723
             Project: Hadoop HBase
          Issue Type: Bug
          Components: thrift
            Reporter: Matthias Lehmann
             Fix For: 0.20.0


The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:

In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.

It needs to be clearified, which one is the desired behavior.

I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1723:
-------------------------

    Resolution: Won't Fix
        Status: Resolved  (was: Patch Available)

Subsumed by new Lars Francke thrift 0.2 API work HBASE-1744

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.20.0
>            Reporter: Matthias Lehmann
>            Assignee: Tim Sell
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723-v2.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739133#action_12739133 ] 

stack commented on HBASE-1723:
------------------------------

No worries Matias. Thanks for looking out for our thrift API.

For first error, make the hadoop jar come before the hbase jar or the dir with hbase webapps in it.... .CLASSPATH is a little tricky. Or run on the cmdline: ant test -Dtestcase=TestThriftServer. Ant test has CLASSPATH set right. On second error, my guess is that its a follow on from first?

Test passes for me. 

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1723:
-------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed to 0.20 branch and TRUNK.  Thanks for the patch Mathias.

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "Anonymous (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anonymous updated HBASE-1723:
-----------------------------

    Affects Version/s: 0.20.0
               Status: Patch Available  (was: Reopened)

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.20.0
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.1
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754316#action_12754316 ] 

ryan rawson commented on HBASE-1723:
------------------------------------

'setTimeStamp' says 'retrieve values AT this exact timestamp'.  When I Was fixing the thrift tests, the tests suggested that the API was 'retrieve me a vision of the past that is at this timestamp' which implies 'setTimeRange(0,providedTimestamp)'.

Retrieving exactly TS=X is rarely correct behaviour since you rely on millisecond precise matching, and unless you are using explicit TS, its fairly unlikely this will match. Whereas saying 'all cells older than TS=X' works much better.

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.20.0
>            Reporter: Matthias Lehmann
>            Assignee: Tim Sell
>             Fix For: 0.20.1
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723-v2.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1723:
-------------------------

    Fix Version/s:     (was: 0.20.0)
                   0.20.1

Move to 0.20.1

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.1
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1723:
-------------------------

    Assignee: Tim Sell

@Tim: I know you are on your holidays but should we apply this to 0.20.1?  It changes behavior, so its like 0.19.x, but changes it.  Need a thrift-head to say yeah or nay!

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.20.0
>            Reporter: Matthias Lehmann
>            Assignee: Tim Sell
>             Fix For: 0.20.1
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723-v2.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "Matthias Lehmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Lehmann updated HBASE-1723:
------------------------------------

    Status: Patch Available  (was: Open)

Use get.setTimeStamp instead of get.setTimeRange

This patch rearranges getRowWithColumnsTs a bit, because the original version was unneccessary repetitive.

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "Matthias Lehmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738969#action_12738969 ] 

Matthias Lehmann commented on HBASE-1723:
-----------------------------------------

Sorry for the inconveniences caused. I'm trying to fix the tests, yet my problem is, that the test-case failes even without the patch.

When I run the TestThriftServer test, I get an exception "java.io.FileNotFoundException: file:/home/mat/work/lalisio/hbase-trunk/build/webapps/datanode" 
and later it fails with "testAll(org.apache.hadoop.hbase.thrift.TestThriftServer)org.apache.hadoop.hbase.client.NoServerForRegionException: No server address listed in -ROOT- for region .META.,,1"

What am I missing?

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reopened HBASE-1723:
--------------------------


Reopening.  Breaks TestThriftServer.  Removed patch from 0.20 branch and TRUNK.

Mathias, looks like the unit test needs to be changed to match this change in behavior.  Any chance of your taking a look?

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802267#action_12802267 ] 

Lars Francke commented on HBASE-1723:
-------------------------------------

I believe this is another issue that is overridden by the new Thrift API from HBASE-1744 and it can be closed as "won't fix"

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.20.0
>            Reporter: Matthias Lehmann
>            Assignee: Tim Sell
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723-v2.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1723:
-------------------------

    Fix Version/s:     (was: 0.20.1)

Ok.  The behavior is different from 0.19.x but lets leave it as is since its more likely what folks want.  Moving out of 0.20.1.

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.20.0
>            Reporter: Matthias Lehmann
>            Assignee: Tim Sell
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723-v2.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737197#action_12737197 ] 

stack commented on HBASE-1723:
------------------------------

Patch looks good.  Yes, the method should work as it used to.

I don't think this issue of enough import to sink the current 0.20.0 RC1.  Lets leave it filed against 0.20.0 and add it in if we end up making a new RC.

Will commit later to TRUNK and if it doesn't make 0.20.0, to 0.20.1.

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "Matthias Lehmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Lehmann updated HBASE-1723:
------------------------------------

    Attachment: HBASE-1723.patch

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "Matthias Lehmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Lehmann updated HBASE-1723:
------------------------------------

    Attachment: HBASE-1723-v2.patch

substitute setTimeRange with setTimeStamp in several methods for consistent behavior.
Also adjust TestThriftServer.

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.20.0
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.1
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723-v2.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "Matthias Lehmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Lehmann updated HBASE-1723:
------------------------------------

    Attachment: HBASE-1723-no-rearrangement.patch

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Matthias Lehmann
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1723) getRowWithColumnsTs changed behavior

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753912#action_12753912 ] 

Tim Sell commented on HBASE-1723:
---------------------------------

I vaguely recall this changing after Ryan updated it for the new java client? So was maybe intentional.
If not, I think the current thrift interface suggests the 19 behavior anyway, so +1.

~Tim.

> getRowWithColumnsTs changed behavior
> ------------------------------------
>
>                 Key: HBASE-1723
>                 URL: https://issues.apache.org/jira/browse/HBASE-1723
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.20.0
>            Reporter: Matthias Lehmann
>            Assignee: Tim Sell
>             Fix For: 0.20.1
>
>         Attachments: HBASE-1723-no-rearrangement.patch, HBASE-1723-v2.patch, HBASE-1723.patch
>
>
> The method getRowWithTimestampTs of the thrift interface changed behavior from version 0.19 to 0.20:
> In 0.19, it returned only cells with exactly the given timestamp, 0.20 it to returns cells with a timestamp before (not including) the given timestamp.
> It needs to be clearified, which one is the desired behavior.
> I attach a patch to make 0.20 conform with 0.19 (only return cells with exactly the given timestamp), if this is what is wanted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.