[GitHub] [ignite-3] rpuch commented on a diff in pull request #1559: IGNITE-18531 Destroy indices when destroying VolatilePageMemoryMvPartitionStorage

["rpuch (via GitHub)" <gi...@apache.org>]

rpuch commented on code in PR #1559:
URL: https://github.com/apache/ignite-3/pull/1559#discussion_r1083699021


##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -1018,9 +1016,6 @@ protected List<AutoCloseable> getResourcesToClose() {
         hashIndexes.values().forEach(index -> resources.add(index::close));
         sortedIndexes.values().forEach(index -> resources.add(index::close));
 
-        resources.add(hashIndexes::clear);

Review Comment:
   When destroying a partition storage, we first close it to make sure no regular operations are possible with it; after that, we start its destruction (including indices). If we clear `hashIndexes` on close, we will not be able to destroy them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org