You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "David S. Wang (JIRA)" <ji...@apache.org> on 2012/06/16 01:59:42 UTC
[jira] [Created] (HBASE-6220) PersistentMetricsTimeVaryingRate gets
used for non-time-based metrics
David S. Wang created HBASE-6220:
------------------------------------
Summary: PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
Key: HBASE-6220
URL: https://issues.apache.org/jira/browse/HBASE-6220
Project: HBase
Issue Type: Bug
Components: metrics
Affects Versions: 0.96.0
Reporter: David S. Wang
Priority: Minor
PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401085#comment-13401085 ]
Paul Cavallaro commented on HBASE-6220:
---------------------------------------
The "_avg_time" is hardcoded in org.apache.hadoop.metrics.util.MetricsTimeVaryingRate in hadoop-core. I could duplicate the functionality in order to change the String, or try to get a change pushed upstream. Both solutions seem like overkill. I also noticed that the underlying metrics package is deprecated and the metrics2 package seems to be the way forward. As I am a "noob" does anyone have thoughts on what the proper approach might be?
Thanks,
-Paul
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Priority: Minor
> Labels: noob
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417369#comment-13417369 ]
Hudson commented on HBASE-6220:
-------------------------------
Integrated in HBase-TRUNK #3144 (See [https://builds.apache.org/job/HBase-TRUNK/3144/])
HBASE-6419 PersistentMetricsTimeVaryingRate gets used for non-time-based metrics (part2 of HBASE-6220) (Paul Cavallaro) (Revision 1363016)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch, ServerMetrics_HBASE_6220_Flush_Metrics.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410331#comment-13410331 ]
David S. Wang commented on HBASE-6220:
--------------------------------------
Apologies for not getting to this earlier.
I noticed that the flush metrics were not changed in the patch. Was there a reason for that?
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408166#comment-13408166 ]
Zhihong Ted Yu commented on HBASE-6220:
---------------------------------------
Patch integrated to trunk.
Thanks for the patch, Paul.
Thanks for the review, Elliot.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412230#comment-13412230 ]
Paul Cavallaro commented on HBASE-6220:
---------------------------------------
Sorry I've been away this week with intermittent internet connectivity. I'll try to reply to all of this soon.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401212#comment-13401212 ]
Hadoop QA commented on HBASE-6220:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533426/ServerMetrics_HBASE_6220.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2254//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2254//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2254//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2254//console
This message is automatically generated.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408407#comment-13408407 ]
Paul Cavallaro commented on HBASE-6220:
---------------------------------------
@stack I don't think it did. :)
I'll take a look soon, hopefully this weekend, as I'm not completely sure.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6220) PersistentMetricsTimeVaryingRate gets
used for non-time-based metrics
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6220:
----------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch, ServerMetrics_HBASE_6220_Flush_Metrics.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408619#comment-13408619 ]
stack commented on HBASE-6220:
------------------------------
@Paul Easy test is browse to /jmx on regionserver. Look for your new metrics messings. Thanks for the contrib.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6220) PersistentMetricsTimeVaryingRate gets
used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Cavallaro updated HBASE-6220:
----------------------------------
Status: Patch Available (was: Open)
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408139#comment-13408139 ]
Elliott Clark commented on HBASE-6220:
--------------------------------------
looks good to me. Have you verified that the changed metrics then get out to jmx?
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416842#comment-13416842 ]
Hadoop QA commented on HBASE-6220:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12536928/ServerMetrics_HBASE_6220_Flush_Metrics.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//console
This message is automatically generated.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch, ServerMetrics_HBASE_6220_Flush_Metrics.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6220) PersistentMetricsTimeVaryingRate gets
used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Cavallaro updated HBASE-6220:
----------------------------------
Attachment: ServerMetrics_HBASE_6220.patch
I moved over the metrics that used PersistentMetricsTimeVaryingRate to MetricsHistogram because it seemed like a better fit.
No tests are included, but I am looking for feedback for correct approach, and what areas to test. I could not find any tests that exercised RegionServerMetrics or MasterServerMetrics, so I did not have much to crib off of.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401129#comment-13401129 ]
Paul Cavallaro commented on HBASE-6220:
---------------------------------------
Sorry, I forgot to add that this obviously changes the metrics that are logged, and I am not sure if that is OK. Obviously this is something to consider.
Thanks,
-Paul
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417135#comment-13417135 ]
stack commented on HBASE-6220:
------------------------------
I made HBASE-6419 to apply Pauls' amendment.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch, ServerMetrics_HBASE_6220_Flush_Metrics.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu reassigned HBASE-6220:
-------------------------------------
Assignee: Paul Cavallaro
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416765#comment-13416765 ]
Paul Cavallaro commented on HBASE-6220:
---------------------------------------
Hey all, back from the offline world, replies below:
@stack Yep, everything seems to show up in /jmx just fine.
@David Wang No reason that it wasn't included, I've actually attached another patch to switch those over the Metrics Histogram as well if desired we can include it.
Thanks all, and sorry for the slow responses.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch, ServerMetrics_HBASE_6220_Flush_Metrics.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6220) PersistentMetricsTimeVaryingRate gets
used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Cavallaro updated HBASE-6220:
----------------------------------
Attachment: ServerMetrics_HBASE_6220_Flush_Metrics.patch
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch, ServerMetrics_HBASE_6220_Flush_Metrics.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408082#comment-13408082 ]
Paul Cavallaro commented on HBASE-6220:
---------------------------------------
>From the mailing list I assume this is getting swallowed up by the push to use metrics2 in https://issues.apache.org/jira/browse/HBASE-4050. Let me know what action I should take as I am a new contributor.
Thanks,
-Paul
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401100#comment-13401100 ]
Elliott Clark commented on HBASE-6220:
--------------------------------------
Creating another class is probably the correct way. See how MetricsHistogram does it. Though there is a push to re-vamp the metrics usage in hbase so things could change with that.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Priority: Minor
> Labels: noob
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Paul Cavallaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417388#comment-13417388 ]
Paul Cavallaro commented on HBASE-6220:
---------------------------------------
Should I resolve this or someone else? Thanks.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch, ServerMetrics_HBASE_6220_Flush_Metrics.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408347#comment-13408347 ]
stack commented on HBASE-6220:
------------------------------
Did Elliott's question of Paul get answered? i.e. if the metrics come out in jmx (and in /jmx servlet?) Good stuff.
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6220) PersistentMetricsTimeVaryingRate
gets used for non-time-based metrics
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417856#comment-13417856 ]
Hudson commented on HBASE-6220:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #98 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/98/])
HBASE-6419 PersistentMetricsTimeVaryingRate gets used for non-time-based metrics (part2 of HBASE-6220) (Paul Cavallaro) (Revision 1363016)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
> Key: HBASE-6220
> URL: https://issues.apache.org/jira/browse/HBASE-6220
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: David S. Wang
> Assignee: Paul Cavallaro
> Priority: Minor
> Labels: noob
> Attachments: ServerMetrics_HBASE_6220.patch, ServerMetrics_HBASE_6220_Flush_Metrics.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading to confusing names such as "avg_time" for compaction size, etc. You hav to read the code in order to understand that this is actually referring to bytes, not seconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira