You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/20 02:57:41 UTC

[GitHub] [airflow] josh-fell commented on a change in pull request #17099: Adding EdgeModifier support for chain()

josh-fell commented on a change in pull request #17099:
URL: https://github.com/apache/airflow/pull/17099#discussion_r672770679



##########
File path: airflow/models/baseoperator.py
##########
@@ -1546,13 +1546,17 @@ def inherits_from_dummy_operator(self):
         return getattr(self, '_is_dummy', False)
 
 
-def chain(*tasks: Union[BaseOperator, "XComArg", Sequence[Union[BaseOperator, "XComArg"]]]):
+def chain(
+    *tasks: Union[
+        BaseOperator, "XComArg", EdgeModifier, Sequence[Union[BaseOperator, "XComArg", EdgeModifier]]

Review comment:
       Brilliant. I'm sure there will be other types that will be "chainable" in the future.  I agree the annotations are beginning to become unwieldy.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org