You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2016/08/31 17:41:31 UTC
[07/13] logging-log4j2 git commit: Use try-with-resources.
Use try-with-resources.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/370ea6c6
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/370ea6c6
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/370ea6c6
Branch: refs/heads/master
Commit: 370ea6c68d3af73497debc3c2d5dc7f35eb0c91d
Parents: 3ca829c
Author: Gary Gregory <gg...@apache.org>
Authored: Sun Aug 28 13:42:55 2016 -0700
Committer: Gary Gregory <gg...@apache.org>
Committed: Sun Aug 28 13:42:55 2016 -0700
----------------------------------------------------------------------
.../appender/NoSqlDatabaseManagerTest.java | 40 +++++++++-----------
1 file changed, 17 insertions(+), 23 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/370ea6c6/log4j-nosql/src/test/java/org/apache/logging/log4j/nosql/appender/NoSqlDatabaseManagerTest.java
----------------------------------------------------------------------
diff --git a/log4j-nosql/src/test/java/org/apache/logging/log4j/nosql/appender/NoSqlDatabaseManagerTest.java b/log4j-nosql/src/test/java/org/apache/logging/log4j/nosql/appender/NoSqlDatabaseManagerTest.java
index 328ce31..5209be2 100644
--- a/log4j-nosql/src/test/java/org/apache/logging/log4j/nosql/appender/NoSqlDatabaseManagerTest.java
+++ b/log4j-nosql/src/test/java/org/apache/logging/log4j/nosql/appender/NoSqlDatabaseManagerTest.java
@@ -92,34 +92,28 @@ public class NoSqlDatabaseManagerTest {
}
@Test
- public void testWriteInternalNotConnected01() {
- replay(this.provider, this.connection);
+ public void testWriteInternalNotConnected01() {
+ replay(this.provider, this.connection);
- final NoSqlDatabaseManager<?> manager = NoSqlDatabaseManager.getNoSqlDatabaseManager("name", 0, this.provider);
+ try (final NoSqlDatabaseManager<?> manager = NoSqlDatabaseManager.getNoSqlDatabaseManager("name", 0,
+ this.provider)) {
- try {
- verify(this.provider, this.connection);
- reset(this.provider, this.connection);
+ verify(this.provider, this.connection);
+ reset(this.provider, this.connection);
- final LogEvent event = createStrictMock(LogEvent.class);
- replay(this.provider, this.connection, event);
+ final LogEvent event = createStrictMock(LogEvent.class);
+ replay(this.provider, this.connection, event);
- try {
- manager.writeInternal(event);
- fail("Expected AppenderLoggingException.");
- } catch (final AppenderLoggingException ignore) {
- /* */
- }
+ try {
+ manager.writeInternal(event);
+ fail("Expected AppenderLoggingException.");
+ } catch (final AppenderLoggingException ignore) {
+ /* */
+ }
- verify(event);
- } finally {
- try {
- manager.close();
- } catch (final Throwable ignore) {
- /* */
- }
- }
- }
+ verify(event);
+ }
+ }
@Test
public void testWriteInternalNotConnected02() {