You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "nicolas de loof (JIRA)" <ji...@codehaus.org> on 2007/08/08 09:17:13 UTC
[jira] Created: (MNG-3140) add support for ${basedir} property in
profile activation
add support for ${basedir} property in profile activation
---------------------------------------------------------
Key: MNG-3140
URL: http://jira.codehaus.org/browse/MNG-3140
Project: Maven 2
Issue Type: Improvement
Components: Profiles
Affects Versions: 2.0.7
Reporter: nicolas de loof
Priority: Minor
The profile <activation> supports file based activation (exists/missing), but properties are not supported to set the path.
My project use such a file-based activation, based on some generated-source file :
<activation>
<file>
<missing>target/generated-sources/sql2java.tstamp</missing>
</file>
</activation>
My project is a module, and when I run the project from the parent project the path is considered based on current dir (parent root) and not module root, so the profile gets activated but shouldn't.
There's no support for properties in profile activation. I can understand this as profile can themself change properties. Support for the ${basedir} property could solve this issue. As this is a default maven property, it should be immutable, so have no impact on profiles activations and other properties setup.
I would like to submit a patch, to enhance FileProfileActivator and replace ${basedir} with actual value in isActive, but I don't know where to get the basedir value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Closed: (MNG-3140) add support for ${basedir} property
in profile activation
Posted by Jan Labrie <ja...@gmail.com>.
Hello,
I have made a fix for this problem. It is attached to
http://jira.codehaus.org/browse/MNG-2363
http://jira.codehaus.org/browse/MNG-2363 .
What has to be done to have this included in a new release of Maven?
Regards,
Jan Labrie
--
View this message in context: http://www.nabble.com/-jira--Created%3A-%28MNG-3140%29-add-support-for-%24%7Bbasedir%7D-property-in-profile-activation-tp12048297p24114005.html
Sent from the Maven - Issues mailing list archive at Nabble.com.
[jira] Commented: (MNG-3140) add support for ${basedir} property in
profile activation
Posted by "rajeev chandrasekaran (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_109345 ]
rajeev chandrasekaran commented on MNG-3140:
--------------------------------------------
it would be very nice to support basedir in the file activation, especially since it is documented as being supported at http://maven.apache.org/pom.html#Activation.
> add support for ${basedir} property in profile activation
> ---------------------------------------------------------
>
> Key: MNG-3140
> URL: http://jira.codehaus.org/browse/MNG-3140
> Project: Maven 2
> Issue Type: Improvement
> Components: Profiles
> Affects Versions: 2.0.7
> Reporter: nicolas de loof
> Priority: Minor
>
> The profile <activation> supports file based activation (exists/missing), but properties are not supported to set the path.
> My project use such a file-based activation, based on some generated-source file :
> <activation>
> <file>
> <missing>target/generated-sources/sql2java.tstamp</missing>
> </file>
> </activation>
> My project is a module, and when I run the project from the parent project the path is considered based on current dir (parent root) and not module root, so the profile gets activated but shouldn't.
> There's no support for properties in profile activation. I can understand this as profile can themself change properties. Support for the ${basedir} property could solve this issue. As this is a default maven property, it should be immutable, so have no impact on profiles activations and other properties setup.
> I would like to submit a patch, to enhance FileProfileActivator and replace ${basedir} with actual value in isActive, but I don't know where to get the basedir value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3140) add support for ${basedir} property in
profile activation
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter closed MNG-3140.
-----------------------------
Assignee: Brett Porter
Resolution: Duplicate
Fix Version/s: (was: 2.0.x)
> add support for ${basedir} property in profile activation
> ---------------------------------------------------------
>
> Key: MNG-3140
> URL: http://jira.codehaus.org/browse/MNG-3140
> Project: Maven 2
> Issue Type: Improvement
> Components: Profiles
> Affects Versions: 2.0.7
> Reporter: nicolas de loof
> Assignee: Brett Porter
> Priority: Minor
>
> The profile <activation> supports file based activation (exists/missing), but properties are not supported to set the path.
> My project use such a file-based activation, based on some generated-source file :
> <activation>
> <file>
> <missing>target/generated-sources/sql2java.tstamp</missing>
> </file>
> </activation>
> My project is a module, and when I run the project from the parent project the path is considered based on current dir (parent root) and not module root, so the profile gets activated but shouldn't.
> There's no support for properties in profile activation. I can understand this as profile can themself change properties. Support for the ${basedir} property could solve this issue. As this is a default maven property, it should be immutable, so have no impact on profiles activations and other properties setup.
> I would like to submit a patch, to enhance FileProfileActivator and replace ${basedir} with actual value in isActive, but I don't know where to get the basedir value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3140) add support for ${basedir} property in
profile activation
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3140:
------------------------------
Fix Version/s: 2.0.x
I would have thought this already worked - perhaps just needs a little investigation
> add support for ${basedir} property in profile activation
> ---------------------------------------------------------
>
> Key: MNG-3140
> URL: http://jira.codehaus.org/browse/MNG-3140
> Project: Maven 2
> Issue Type: Improvement
> Components: Profiles
> Affects Versions: 2.0.7
> Reporter: nicolas de loof
> Priority: Minor
> Fix For: 2.0.x
>
>
> The profile <activation> supports file based activation (exists/missing), but properties are not supported to set the path.
> My project use such a file-based activation, based on some generated-source file :
> <activation>
> <file>
> <missing>target/generated-sources/sql2java.tstamp</missing>
> </file>
> </activation>
> My project is a module, and when I run the project from the parent project the path is considered based on current dir (parent root) and not module root, so the profile gets activated but shouldn't.
> There's no support for properties in profile activation. I can understand this as profile can themself change properties. Support for the ${basedir} property could solve this issue. As this is a default maven property, it should be immutable, so have no impact on profiles activations and other properties setup.
> I would like to submit a patch, to enhance FileProfileActivator and replace ${basedir} with actual value in isActive, but I don't know where to get the basedir value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira