You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/05/14 21:09:21 UTC
[GitHub] [libcloud] havardAasen opened a new pull request, #1694: Use tuple to compare versions for test against Paramiko.
havardAasen opened a new pull request, #1694:
URL: https://github.com/apache/libcloud/pull/1694
## Use tuple to compare versions for test against Paramiko.
### Description
For the test test_key_file_non_pem_format_error() we want to compare and
see if Paramiko version is greater than '2.7.0'. The version is compared as a
string. This breaks when we test against version '2.10' and above.
We change from comparing a string, to comparing a tuple.
This is identical to this commit: 470dc46014e5b89a61a74cb6fd62493c49483a15
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1694: Use tuple to compare versions for test against Paramiko.
Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1694:
URL: https://github.com/apache/libcloud/pull/1694#issuecomment-1126915254
Merged, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter commented on pull request #1694: Use tuple to compare versions for test against Paramiko.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1694:
URL: https://github.com/apache/libcloud/pull/1694#issuecomment-1126821983
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1694?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1694](https://codecov.io/gh/apache/libcloud/pull/1694?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (430b0db) into [trunk](https://codecov.io/gh/apache/libcloud/commit/003040bbcbd3993ccae6e2a45b2da0c5aae9a1dd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (003040b) will **not change** coverage.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/libcloud/pull/1694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1694 +/- ##
=======================================
Coverage 83.25% 83.25%
=======================================
Files 400 400
Lines 87332 87332
Branches 9285 9286 +1
=======================================
Hits 72706 72706
Misses 11466 11466
Partials 3160 3160
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/test/compute/test\_ssh\_client.py](https://codecov.io/gh/apache/libcloud/pull/1694/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfc3NoX2NsaWVudC5weQ==) | `96.41% <50.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1694?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1694?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [003040b...430b0db](https://codecov.io/gh/apache/libcloud/pull/1694?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami merged pull request #1694: Use tuple to compare versions for test against Paramiko.
Posted by GitBox <gi...@apache.org>.
Kami merged PR #1694:
URL: https://github.com/apache/libcloud/pull/1694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] havardAasen commented on pull request #1694: Use tuple to compare versions for test against Paramiko.
Posted by GitBox <gi...@apache.org>.
havardAasen commented on PR #1694:
URL: https://github.com/apache/libcloud/pull/1694#issuecomment-1126869627
I did a force-push. Create a tuple of the version string when Paramiko isn't installed, instead of a list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org