You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/01/31 15:56:47 UTC
[GitHub] [cordova-ios] NiklasMerz opened a new pull request #1069: (chore): update dependencies for minor release
NiklasMerz opened a new pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Working through the release process I found some outdated dependencies:
```
Package Current Wanted Latest Location
find-process 1.4.3 1.4.4 1.4.4 cordova-ios
fs-extra 9.0.1 9.1.0 9.1.0 cordova-ios
ios-sim 8.0.2 8.0.2 9.0.0 cordova-ios
jasmine 3.5.0 3.5.0 3.6.4 cordova-ios
nopt 4.0.3 4.0.3 5.0.0 cordova-ios
semver 7.3.2 7.3.4 7.3.4 cordova-ios
tmp 0.1.0 0.1.0 0.2.1 cordova-ios
```
### Description
<!-- Describe your changes in detail -->
I updated dependencies with minor and patch releases and found no issues locking at the release notes and test results.
Some packages turned tests red and are major upgrades. I created an issue for the next version.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Tests and CI
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on pull request #1069: (chore): update dependencies for minor release
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069#issuecomment-770403705
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=h1) Report
> Merging [#1069](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=desc) (71ff20f) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e1cc0966b3594e7afc380f5cd585eb6c5973c7c4?el=desc) (e1cc096) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1069 +/- ##
=======================================
Coverage 74.88% 74.88%
=======================================
Files 13 13
Lines 1724 1724
=======================================
Hits 1291 1291
Misses 433 433
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=footer). Last update [e1cc096...71ff20f](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io commented on pull request #1069: (chore): update dependencies for minor release
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069#issuecomment-770403705
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=h1) Report
> Merging [#1069](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=desc) (71ff20f) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e1cc0966b3594e7afc380f5cd585eb6c5973c7c4?el=desc) (e1cc096) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1069 +/- ##
=======================================
Coverage 74.88% 74.88%
=======================================
Files 13 13
Lines 1724 1724
=======================================
Hits 1291 1291
Misses 433 433
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=footer). Last update [e1cc096...71ff20f](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] NiklasMerz merged pull request #1069: (chore): update dependencies for minor release
Posted by GitBox <gi...@apache.org>.
NiklasMerz merged pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] NiklasMerz commented on pull request #1069: (chore): update dependencies for minor release
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069#issuecomment-770949348
Thank you all for the feedback
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] jcesarmobile commented on pull request #1069: (chore): update dependencies for minor release
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069#issuecomment-770458011
In the comment you say wanted 4.0.3 but updated to 5.0.0.
Also says “minor and patch” but that’s major.
Not saying we shouldn’t update to 5.0.0, only that the description is confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] NiklasMerz commented on pull request #1069: (chore): update dependencies for minor release
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069#issuecomment-770415044
Thanks @breautek for the summary.
Regarding `nopt`: Seems like they just did a small dependency update: https://github.com/npm/nopt/compare/v4.0.3...v5.0.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] jcesarmobile commented on pull request #1069: (chore): update dependencies for minor release
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069#issuecomment-770697643
Just saying that the PR change doesn’t do what you say it does in the or description, you can just update the description
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] NiklasMerz commented on pull request #1069: (chore): update dependencies for minor release
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069#issuecomment-770618690
NPM outdated wanted 4.0.3. Since I did not find dangerous changes in 5.0.0 (see previous comment) I updated to the latest version.
5.0.0 looks save but I can revert that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on pull request #1069: (chore): update dependencies for minor release
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1069:
URL: https://github.com/apache/cordova-ios/pull/1069#issuecomment-770403705
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=h1) Report
> Merging [#1069](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=desc) (1df6063) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e1cc0966b3594e7afc380f5cd585eb6c5973c7c4?el=desc) (e1cc096) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1069 +/- ##
=======================================
Coverage 74.88% 74.88%
=======================================
Files 13 13
Lines 1724 1724
=======================================
Hits 1291 1291
Misses 433 433
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=footer). Last update [e1cc096...1df6063](https://codecov.io/gh/apache/cordova-ios/pull/1069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org