[GitHub] [spark] cloud-fan commented on a diff in pull request #39296: [SPARK-41757][CONNECT] Fixing String representation for Column class

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #39296:
URL: https://github.com/apache/spark/pull/39296#discussion_r1059233553


##########
python/pyspark/sql/connect/expressions.py:
##########
@@ -420,6 +420,12 @@ def __repr__(self) -> str:
             return f"{self._name}({', '.join([str(arg) for arg in self._args])})"
 
 
+class UnresolvedBinaryFunction(UnresolvedFunction):

Review Comment:
   Is our goal to make the Column string representation consistent between client and server? We don't have a general rule about how to generate Column string representation, I think a lot of manual efforts are needed to check the server-side implementation and copy it to the client.
   
   Shall we only take care of some common ones like attribute and literal?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org