You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/07 12:42:27 UTC

[GitHub] [incubator-dolphinscheduler] yangyichao-mango opened a new issue #2922: [BUG] Jackson UDSerde error

yangyichao-mango opened a new issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922


   **Describe the bug**
   
   There is a Serde Exception in `TaskNode`, because we use Jackson UDSerde `JSONUtils.JsonDataSerializer` and `JSONUtils.JsonDataDeserializer` in `TaskNode` fields.
   
   The UDSerde can convert "[]" to ""[]"" because the `JsonDataDeserializer` node.toString() implement.
   
   **To Reproduce**
   Steps to reproduce the behavior, for example:
   
   `public static void main(String[] args) {
           String a = "{\"conditionResult\":\"{\\\"successNode\\\":[\\\"\\\"],\\\"failedNode\\\":[\\\"\\\"]}\","
                   + "\"conditionsTask\":false,\"depList\":[],\"dependence\":\"{}\",\"forbidden\":false,"
                   + "\"id\":\"tasks-86823\",\"maxRetryTimes\":1,\"name\":\"shell test\","
                   + "\"params\":\"{\\\"resourceList\\\":[],\\\"localParams\\\":[],\\\"rawScript\\\":\\\"echo "
                   + "'yyc'\\\"}\",\"preTasks\":\"[]\",\"retryInterval\":1,\"runFlag\":\"NORMAL\","
                   + "\"taskInstancePriority\":\"HIGHEST\",\"taskTimeoutParameter\":{\"enable\":false,\"interval\":0},"
                   + "\"timeout\":\"{}\",\"type\":\"SHELL\",\"workerGroup\":\"default\"}";
   
           TaskNode taskNode = JSONUtils.parseObject(a, TaskNode.class);
       }`
   
   
   **Expected behavior**
   `com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot deserialize instance of `java.util.ArrayList` out of VALUE_STRING token
    at [Source: (String)""[]""; line: 1, column: 1]`
   
   **Screenshots**
   ![image](https://user-images.githubusercontent.com/29545877/83968921-f98abc80-a8fe-11ea-8765-94829ce5dedd.png)
   
   
   **Which version of Dolphin Scheduler:**
    -[1.3.0]
   
   **Requirement or improvement
   - We can remove the UDSerde `JSONUtils.JsonDataSerializer` and `JSONUtils.JsonDataDeserializer` in JSONUtils.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] lgcareer edited a comment on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
lgcareer edited a comment on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640417774


   Hi,Thanks.The branch is the develop branch,If you want tu use ds,don't suggest use dev branch.If you want to coutribute,you can test dev and commit pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640406797


   > Hi,I test it on dev-1.3.0 is ok,You can test it on dev-1.3.0 branch.
   
   I run it in dev branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] dailidong closed issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
dailidong closed issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] lgcareer commented on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
lgcareer commented on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640417774


   Hi,Thanks.The branch is out develop branch,If you want tu use ds,don't suggest use dev branch.If you want to coutribute,you can test dev and commit pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] lgcareer commented on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
lgcareer commented on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640404928


   Hi,I test it on dev-1.3.0 is ok,You can test it on dev-1.3.0 branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640398212


   > Whether do gou give a whole step,such as how to create a process definition? and how to run? I visit the task instance list is normal.
   
   1.Create a Shell task.
   ![image](https://user-images.githubusercontent.com/29545877/83999011-74ea7d80-a994-11ea-9fde-9ffffcaf8341.png)
   
   2.Deploy the work flow and run it manually.
   ![image](https://user-images.githubusercontent.com/29545877/83999103-a2cfc200-a994-11ea-8570-9d124917bea8.png)
   
   3.It will cause an exception when I visit this page.
   ![image](https://user-images.githubusercontent.com/29545877/83999174-ca268f00-a994-11ea-89f8-9a4e86deb1b7.png)
   
   4.The exception is below.
   ![image](https://user-images.githubusercontent.com/29545877/83999238-eaeee480-a994-11ea-9366-9edc7c1431f7.png)
   
   Thx for your answer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640418919


   > Hi,Thanks.The branch is the develop branch,If you want tu use ds,don't suggest use dev branch.If you want to coutribute,you can test dev and commit pr.
   
   Thx for your answer.
   I'm a starter and use dev branch in my local env. I will fix it and commit a PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640398212


   > Whether do gou give a whole step,such as how to create a process definition? and how to run? I visit the task instance list is normal.
   
   1.Create a Shell task.
   ![image](https://user-images.githubusercontent.com/29545877/83999011-74ea7d80-a994-11ea-9fde-9ffffcaf8341.png)
   
   2.Deploy the work flow and run it manually.
   ![image](https://user-images.githubusercontent.com/29545877/83999103-a2cfc200-a994-11ea-8570-9d124917bea8.png)
   
   3.It will cause an exception when I visit this page.
   ![image](https://user-images.githubusercontent.com/29545877/83999174-ca268f00-a994-11ea-89f8-9a4e86deb1b7.png)
   
   4.The exception is below.
   ![image](https://user-images.githubusercontent.com/29545877/83999238-eaeee480-a994-11ea-9366-9edc7c1431f7.png)
   
   Thx for your answer.
   I run that in dev branch code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] lgcareer edited a comment on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
lgcareer edited a comment on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640347625


   Hi,I didn't find the exception occurs,whether give a whole picture


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] lgcareer commented on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
lgcareer commented on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640393916


   Whether do gou give a whole step,such as how to create a process definition? and how to run? I visit the task instance list is normal.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] lgcareer commented on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
lgcareer commented on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640347625


   Hi,I didn't fid the exception occurs,whether give a whole picture


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640406797


   > Hi,I test it on dev-1.3.0 is ok,You can test it on dev-1.3.0 branch.
   
   I run it in dev branch and there is a exception.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #2922: [BUG] Jackson UDSerde error

Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on issue #2922:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2922#issuecomment-640350408


   > Hi,I didn't find the exception occurs,whether give a whole picture
   
   You can test this rest api below.
   ![image](https://user-images.githubusercontent.com/29545877/83991428-4ada9080-a97f-11ea-8c42-4ee82770bc7b.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org