[kudu-CR] [tests] use system unsync time source for tests by default

["Adar Dembo (Code Review)" <ge...@cloudera.org>]

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14379 )

Change subject: [tests] use system_unsync time source for tests by default
......................................................................


Patch Set 3:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:

http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/clock/hybrid_clock.cc@61
PS3, Line 61:  In case of test
            : // environment, there is no need to require NTP-synchronized clock to run
            : // a generic Kudu test. All the participating test components are run at the
            : // same node, and using the same local clock for every component makes the
            : // synchronisation of clocks unnecessary, so in tests the time source is set
            : // to 'system_unsync' by default: see KuduTest::SetUp() for details.
Is this part of the comment relevant to this line of code?


http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/mini-cluster/external_mini_cluster.cc
File src/kudu/mini-cluster/external_mini_cluster.cc:

http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/mini-cluster/external_mini_cluster.cc@191
PS3, Line 191:     flags->emplace_back(Substitute("--time_source=$0", "system_unsync"));
Don't we want to call this when NO_CHRONY is defined?


http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/scripts/start_kudu.sh
File src/kudu/scripts/start_kudu.sh:

http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/scripts/start_kudu.sh@29
PS3, Line 29: Usage:
Update this.


http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/util/CMakeLists.txt
File src/kudu/util/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/util/CMakeLists.txt@334
PS3, Line 334:   clock
Not necessary given the way in which the gflag is manipulated.


http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:

http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/util/test_util.cc@69
PS3, Line 69: DECLARE_string(time_source);
Not used?


http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/util/test_util.cc@115
PS3, Line 115: compoents
components


http://gerrit.cloudera.org:8080/#/c/14379/3/src/kudu/util/test_util.cc@122
PS3, Line 122: glags
gflags



-- 
To view, visit http://gerrit.cloudera.org:8080/14379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7edbf884afaa19121aa92a4ce93c8a7eeb2d937
Gerrit-Change-Number: 14379
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Dec 2019 05:00:09 +0000
Gerrit-HasComments: Yes