You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2018/03/22 05:30:39 UTC
svn commit: r1827457 -
/ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
Author: jleroux
Date: Thu Mar 22 05:30:39 2018
New Revision: 1827457
URL: http://svn.apache.org/viewvc?rev=1827457&view=rev
Log:
Fixed: Convert README.md to README.adoc.
(OFBIZ-10272)
Not sure why it went unnoticed so long, but by removing README.md
(replacing README.adoc) r1827046 brokes testZipReadme
Not a big deal, we can just replace the file in the test (from README.md to
README.adoc). We could chose a more sure to remain file, but I guess that now we
are going with asciidoc and README.adoc should stay
Modified:
ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
Modified: ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy?rev=1827457&r1=1827456&r2=1827457&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy (original)
+++ ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy Thu Mar 22 05:30:39 2018
@@ -31,7 +31,7 @@ class FileUtilTests extends GroovyScript
void testZipReadme() {
String zipFilePath = UtilProperties.getPropertyValue("general", "http.upload.tmprepository", "runtime/tmp")
String zipName = 'README.md.zip'
- String fileName = 'README.md'
+ String fileName = 'README.adoc'
File originalReadme = new File(fileName)
//validate zipStream from README.md is not null
Re: svn commit: r1827457 -
/ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests
.groovy
Posted by Jacques Le Roux <ja...@les7arts.com>.
You'r right, thanks Gil
Jacques
Le 22/03/2018 à 08:48, gil portenseigne a écrit :
> Indeed, thanks Jacques for the fix.
>
> I'll just complete it renaming the zipName to README.adoc.zip :), not a big deal but for consistency it's better.
>
> Gil
>
>
> On 22/03/2018 06:30, jleroux@apache.org wrote:
>> Author: jleroux
>> Date: Thu Mar 22 05:30:39 2018
>> New Revision: 1827457
>>
>> URL: http://svn.apache.org/viewvc?rev=1827457&view=rev
>> Log:
>> Fixed: Convert README.md to README.adoc.
>> (OFBIZ-10272)
>>
>> Not sure why it went unnoticed so long, but by removing README.md
>> (replacing README.adoc) r1827046 brokes testZipReadme
>>
>> Not a big deal, we can just replace the file in the test (from README.md to
>> README.adoc). We could chose a more sure to remain file, but I guess that now we
>> are going with asciidoc and README.adoc should stay
>>
>> Modified:
>> ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
>>
>> Modified: ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy?rev=1827457&r1=1827456&r2=1827457&view=diff
>> ==============================================================================
>> --- ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy (original)
>> +++ ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy Thu Mar 22 05:30:39 2018
>> @@ -31,7 +31,7 @@ class FileUtilTests extends GroovyScript
>> void testZipReadme() {
>> String zipFilePath = UtilProperties.getPropertyValue("general", "http.upload.tmprepository", "runtime/tmp")
>> String zipName = 'README.md.zip'
>> - String fileName = 'README.md'
>> + String fileName = 'README.adoc'
>> File originalReadme = new File(fileName)
>> //validate zipStream from README.md is not null
>>
>>
>
>
Re: svn commit: r1827457 -
/ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
Posted by gil portenseigne <gi...@nereide.fr>.
Indeed, thanks Jacques for the fix.
I'll just complete it renaming the zipName to README.adoc.zip :), not a
big deal but for consistency it's better.
Gil
On 22/03/2018 06:30, jleroux@apache.org wrote:
> Author: jleroux
> Date: Thu Mar 22 05:30:39 2018
> New Revision: 1827457
>
> URL: http://svn.apache.org/viewvc?rev=1827457&view=rev
> Log:
> Fixed: Convert README.md to README.adoc.
> (OFBIZ-10272)
>
> Not sure why it went unnoticed so long, but by removing README.md
> (replacing README.adoc) r1827046 brokes testZipReadme
>
> Not a big deal, we can just replace the file in the test (from README.md to
> README.adoc). We could chose a more sure to remain file, but I guess that now we
> are going with asciidoc and README.adoc should stay
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy?rev=1827457&r1=1827456&r2=1827457&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy Thu Mar 22 05:30:39 2018
> @@ -31,7 +31,7 @@ class FileUtilTests extends GroovyScript
> void testZipReadme() {
> String zipFilePath = UtilProperties.getPropertyValue("general", "http.upload.tmprepository", "runtime/tmp")
> String zipName = 'README.md.zip'
> - String fileName = 'README.md'
> + String fileName = 'README.adoc'
> File originalReadme = new File(fileName)
>
> //validate zipStream from README.md is not null
>
>